feat: add customize.enabled option and complete env var docs#207
Conversation
The environment variables table was missing most options. Added all variables derived from setting.go: server/path settings, logger, customize options (disableKillCount, headerTitle, headerSubtitle), and conversion settings (batchSize, chunkSize, retryFailed).
Summary of ChangesHello @fank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's documentation by providing a comprehensive list of all supported environment variables in the README.md file. This update ensures that users have a complete reference for configuring the application, covering server, path, logging, customization, and conversion settings, with accurate default values. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the documentation by listing all supported environment variables in the README. The added information is clear, accurate, and will be very helpful for users setting up the application with Docker. I've suggested a minor formatting improvement to enhance readability, but overall this is a solid contribution.
When disabled (the default), GET /api/v1/customize returns 204 No Content. When enabled, it returns the customize settings as before.
When customize is disabled, the backend returns 204. The fetchJson helper would try to parse the empty body as JSON, causing a console error. Now getCustomize handles 204 explicitly by returning an empty config object.
Coverage Report for ui
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
The standalone CustomizeLogo component floated over the map and looked out of place. Move the logo into the TopBar left section (between the back button and mission info), matching the MissionSelector's approach. Delete the now-unused CustomizeLogo component and its CSS module.
Display the branding between the logo and mission info, separated by a subtle divider. Only renders when headerTitle is configured.
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
fank
changed the title
1 participant
Summary
customize.enabledoption to gate the/api/v1/customizeendpoint — returns 204 No Content when disabled (default)ApiClient.getCustomize()so it returns an empty config without console errorsheaderTitleandheaderSubtitlein the playback TopBar between branding and mission infoTest plan
TestGetCustomize/enabledandTestGetCustomize/disabledpassApiClient.getCustomize204 test passes