Skip to content

Remove duplicate mission_data/time metric#50

Merged
fank merged 1 commit intomainfrom
chore/remove-duplicate-time-metric
Feb 13, 2026
Merged

Remove duplicate mission_data/time metric#50
fank merged 1 commit intomainfrom
chore/remove-duplicate-time-metric

Conversation

@fank
Copy link
Member

@fank fank commented Feb 13, 2026

Summary

  • Remove the :METRIC: mission_data/time block from fnc_metricsLoop.sqf
  • This data (timeMultiplier, serverTime, diag_tickTime, accTime) is redundant — the authoritative time state is already sent via :NEW:TIME:STATE: in fnc_updateTime.sqf, which is tied to capture frame numbers for playback correlation

Test plan

  • Verify InfluxDB weather and other metrics still arrive
  • Verify OCAP playback timeline is unaffected (uses :NEW:TIME:STATE:)

This data is already captured by :NEW:TIME:STATE: in fnc_updateTime.sqf
which is tied to capture frames for playback correlation. The InfluxDB
metric was redundant.
@gemini-code-assist
Copy link

Summary of Changes

Hello @fank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes data reporting by eliminating a duplicate time-related metric. The mission_data/time metric, previously transmitted from fnc_metricsLoop.sqf, was found to be redundant as the same time state information is already provided by fnc_updateTime.sqf. This change reduces unnecessary data transmission and improves system efficiency without affecting critical functionalities like OCAP playback or other metric collection.

Highlights

  • Redundant Metric Removal: The :METRIC: block for mission_data/time has been removed from fnc_metricsLoop.sqf. This metric, which included diag_tickTime, serverTime, timeMultiplier, and accTime, was redundant as the authoritative time state is already sent via :NEW:TIME:STATE: in fnc_updateTime.sqf.
Changelog
  • addons/database/fnc_metricsLoop.sqf
    • Removed the :METRIC: block responsible for sending mission_data/time metrics, including diag_tickTime, serverTime, timeMultiplier, and accTime.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a redundant metric block for mission_data/time from fnc_metricsLoop.sqf. The change is straightforward and aligns with the description, which states this data is already being sent through another mechanism. The removal of this duplicate metric is a good cleanup and should help reduce unnecessary data transmission. The implementation is correct and I have no further suggestions.

@fank fank merged commit 286e727 into main Feb 13, 2026
1 check passed
@fank fank deleted the chore/remove-duplicate-time-metric branch February 13, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant