Filter parachute/ejection seat kill events and fix dead parachute tracking

[fank]

Summary

• Skip parachute/ejection seat vehicles in EntityKilled handler to eliminate noisy events like "Ejection Seat destroyed by Ejection Seat" and "Steerable Parachute destroyed by Shah"
• Expand parachute exclusion in capture loop to also stop tracking dead parachutes (alive=0) regardless of crew state — previously only empty parachutes were excluded, leaving dead-but-occupied parachutes as persistent gray icons

Test plan

• Start mission with aircraft, eject pilots — verify no ejection seat/parachute kill events in recording
• Destroy aircraft near parachutes (splash damage) — verify dead parachutes disappear from playback within one frame
• Normal gameplay kill events still recorded correctly

[gemini-code-assist]

Summary of Changes

Hello @fank, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the recording system by eliminating unnecessary "kill" events generated by parachutes and ejection seats, and by improving the tracking of parachutes to ensure dead ones are no longer displayed. These changes enhance the clarity and accuracy of recorded gameplay data by reducing noise and correctly reflecting the state of game entities.

Highlights

• Filter noisy kill events: Implemented logic to skip parachute and ejection seat vehicles in the EntityKilled handler, preventing irrelevant events like "Ejection Seat destroyed by Ejection Seat" from being recorded.
• Improve dead parachute tracking: Expanded the parachute exclusion in the capture loop to stop tracking dead parachutes (alive=0), ensuring they disappear from playback regardless of crew state, addressing cases where dead-but-occupied parachutes remained as persistent icons.

Changelog

• addons/recorder/fnc_captureLoop.sqf
  • Modified the condition for stopping parachute/ejection seat tracking to include instances where the vehicle is not alive in addition to being empty.
• addons/recorder/fnc_eh_killed.sqf
  • Added an early exit condition to prevent processing kill events for victims identified as "parachute" vehicles.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to filter out kill events from parachutes/ejection seats and improve tracking of dead parachutes. The change in fnc_eh_killed.sqf correctly filters the kill events. However, the logic for tracking dead parachutes in fnc_captureLoop.sqf contains a syntax error that will prevent it from working as intended. I've provided a suggestion to fix this critical issue.