Compatibility with Restrict Markers

[mrschick]

The mod Restrict Markers handles any received global marker and turns it into a local one on any client that is close enough to the creator. Internally it handles the markers of a dedicated server so that the server receives any created marker, but does not duplicate it if it is re-shared to others.

However, the re-sharing creates new local markers on clients, which are then recorded by OCAP events and sent to the server. This causes the server to record many duplicated markers, which harms playback performance.

My fix checks whether Restrict Markers is loaded and enabled on the server, and if so blocks any OCAP marker event on clients from being forwarded to the server.

[gemini-code-assist]

Summary of Changes

Hello @mrschick, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances compatibility and improves performance by addressing an issue where the 'Restrict Markers' mod caused excessive duplicate marker data to be sent to the server. The changes introduce a mechanism to detect the mod's presence and, when active, prevent clients from forwarding redundant marker events, thereby optimizing server load and playback efficiency.

Highlights

• Compatibility with Restrict Markers Mod: Implemented a solution to prevent duplicate marker recording when the 'Restrict Markers' mod is active, which previously led to performance issues during playback.
• Client-side Marker Event Blocking: Added a conditional check in the marker handling logic to block OCAP marker events from being forwarded by clients to the server if the 'Restrict Markers' mod is detected and enabled.
• Mod Detection Logic: Introduced a global flag, OCAP_recorder_restrictMarkersCompat, which dynamically checks for the presence and active status of the 'Restrict Markers' mod during initialization.

Changelog

• addons/recorder/fnc_handleMarkers.sqf
  • Introduced a conditional check to prevent client-side marker events from being forwarded to the server when the 'Restrict Markers' mod is active.
• addons/recorder/fnc_init.sqf
  • Implemented logic to detect the presence and activation of the 'Restrict Markers' mod and set a global compatibility flag.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a compatibility fix for the 'Restrict Markers' mod by preventing clients from recording local markers when the mod is active, which correctly avoids duplicate marker entries on the server. The implementation is sound. I've added a couple of suggestions to improve code robustness and maintainability by refactoring duplicated logic and using a safer method for checking global variables.