feat: simpler verification retry to avoid inconclusives #73
+128
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| use crate::verification::HtxVerifier; | ||
|
|
||
| const MAX_ATTEMPTS: u32 = 3; | ||
| const BACKOFF_TIME: std::time::Duration = std::time::Duration::from_secs(10); |
There was a problem hiding this comment.
AMD returns Retry-After in the 429 header. Can we use that instead of 10 seconds? See page 15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This morning we had an issue where multiple nodes were being rejected with
429from AMD certificate download.I've reimplemented the retry mechanism for attempting connections multiple times, and with a spread to handle this case where multiple nodes fail so that the retry happens at different timestamps.