Fix WeaklyTypedFloat Dependency Name #234
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I was able to verify that this fix works with all Spack build combinations of both TensorWrapper and Chemist. |
jwaldrop107
approved these changes
Jan 28, 2026
ryanmrichard
approved these changes
Jan 28, 2026
Contributor
|
🚀 [bumpr] Bumped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No
Description
With
cmaize_find_or_build_dependency, theNAMEfield is used to help match to the actual dependency name (like for casing/formatting quirks). The WeaklyTypedFloat library uses the project name,wtf, so this PR updates theNAMEfield to match while retaining the "WeaklyTypedFloat" name on the CMaize side.As it is currently defined, TensorWrapper cannot be linked to properly once installed since the installation cannot find the WeaklyTypedFloat library anymore.