Skip to content

Enable compile-time evaluation of just senders #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
romintomasetti wants to merge 1 commit into from
+22 −12
Closed

Enable compile-time evaluation of just senders #1780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/stdexec/__detail/__basic_sender.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ namespace STDEXEC {
using __tag_t = __decay_t<_Sexpr>::__tag_t;
using __state_t = __state_type_t<__tag_t, _Sexpr, _Receiver>;

explicit __op_base(_Sexpr&& __sndr, _Receiver&& __rcvr) noexcept(noexcept(
explicit constexpr __op_base(_Sexpr&& __sndr, _Receiver&& __rcvr) noexcept(noexcept(
__state_t(__sexpr_impl<__tag_t>::get_state(__declval<_Sexpr>(), __declval<_Receiver>()))))
: __state_(
__sexpr_impl<__tag_t>::get_state(
Expand Down Expand Up @@ -220,7 +220,7 @@ namespace STDEXEC {
return __impl{__op_}(__indices_for<_Child...>(), static_cast<_Child&&>(__child)...);
}

auto operator()(__ignore, __ignore) const noexcept -> __tuple<> {
constexpr auto operator()(__ignore, __ignore) const noexcept -> __tuple<> {
return {};
}

Expand Down Expand Up @@ -290,7 +290,7 @@ namespace STDEXEC {
using __state_t = __op_state::__op_base::__state_t;
using __inner_ops_t = __apply_result_t<__detail::__connect_fn<_Sexpr, _Receiver>, _Sexpr>;

explicit __op_state(_Sexpr&& __sexpr, _Receiver __rcvr) noexcept(
explicit constexpr __op_state(_Sexpr&& __sexpr, _Receiver __rcvr) noexcept(
__nothrow_constructible_from<__detail::__op_base<_Sexpr, _Receiver>, _Sexpr, _Receiver>
&& __nothrow_applicable<__detail::__connect_fn<_Sexpr, _Receiver>, _Sexpr>)
: __op_state::__op_base{static_cast<_Sexpr&&>(__sexpr), static_cast<_Receiver&&>(__rcvr)}
Expand All @@ -299,7 +299,7 @@ namespace STDEXEC {
static_cast<_Sexpr&&>(__sexpr))) {
}

STDEXEC_ATTRIBUTE(always_inline) void start() & noexcept {
STDEXEC_ATTRIBUTE(always_inline) constexpr void start() & noexcept {
using __tag_t = __op_state::__tag_t;
STDEXEC::__apply(
[&](auto&... __ops) noexcept { __sexpr_impl<__tag_t>::start(this->__state_, __ops...); },
Expand Down
2 changes: 1 addition & 1 deletion include/stdexec/__detail/__domain.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ namespace STDEXEC {

template <class _OpTag, class _Sender, class _Env>
STDEXEC_ATTRIBUTE(always_inline)
auto transform_sender(_OpTag, _Sender&& __sndr, const _Env&) const
constexpr auto transform_sender(_OpTag, _Sender&& __sndr, const _Env&) const
noexcept(__nothrow_move_constructible<_Sender>) -> _Sender {
return static_cast<_Sender>(static_cast<_Sender&&>(__sndr));
}
Expand Down
2 changes: 1 addition & 1 deletion include/stdexec/__detail/__just.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ namespace STDEXEC {

template <__movable_value... _Ts>
STDEXEC_ATTRIBUTE(host, device)
auto operator()(_Ts&&... __ts) const noexcept(__nothrow_decay_copyable<_Ts...>) {
constexpr auto operator()(_Ts&&... __ts) const noexcept(__nothrow_decay_copyable<_Ts...>) {
return __make_sexpr<just_t>(__tuple{static_cast<_Ts&&>(__ts)...});
}
};
Expand Down
2 changes: 1 addition & 1 deletion include/stdexec/__detail/__operation_states.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace STDEXEC {
template <class _Op>
requires __has_start<_Op>
STDEXEC_ATTRIBUTE(always_inline)
void operator()(_Op &__op) const noexcept {
constexpr void operator()(_Op &__op) const noexcept {
static_assert(noexcept(__op.start()), "start() members must be noexcept");
static_assert(__same_as<decltype(__op.start()), void>, "start() members must return void");
__op.start();
Expand Down
2 changes: 1 addition & 1 deletion include/stdexec/__detail/__receivers.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ namespace STDEXEC {
template <class _Receiver, class... _As>
requires __set_value_member<_Receiver, _As...>
STDEXEC_ATTRIBUTE(host, device, always_inline)
void operator()(_Receiver &&__rcvr, _As &&...__as) const noexcept {
constexpr void operator()(_Receiver &&__rcvr, _As &&...__as) const noexcept {
static_assert(
noexcept(static_cast<_Receiver &&>(__rcvr).set_value(static_cast<_As &&>(__as)...)),
"set_value member functions must be noexcept");
Expand Down
2 changes: 1 addition & 1 deletion include/stdexec/__detail/__utility.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ namespace STDEXEC {
// A derived-to-base cast that works even when the base is not accessible from derived.
template <class _Tp, class _Up>
STDEXEC_ATTRIBUTE(host, device)
auto __c_upcast(_Up&& u) noexcept -> __copy_cvref_t<_Up&&, _Tp>
constexpr auto __c_upcast(_Up&& u) noexcept -> __copy_cvref_t<_Up&&, _Tp>
requires __decays_to<_Tp, _Tp>
{
static_assert(STDEXEC_IS_BASE_OF(_Tp, __decay_t<_Up>));
Expand Down
10 changes: 10 additions & 0 deletions test/stdexec/algos/factories/test_just.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,4 +181,14 @@ namespace {
::STDEXEC::start(op);
CHECK(invoked == 1);
}

TEST_CASE("just compile time", "[not][sure]") {
static_assert([](const double value) constexpr -> double {
auto sndr = ::STDEXEC::just(value);
double placeholder = 0;
auto opstate = ::STDEXEC::connect(std::move(sndr), expect_value_receiver_ex{placeholder});
::STDEXEC::start(opstate);
return placeholder;
}(42) == 42);
}
} // namespace
6 changes: 3 additions & 3 deletions test/test_common/receivers.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ namespace {
public:
using receiver_concept = STDEXEC::receiver_t;

explicit expect_value_receiver_ex(T& dest)
explicit constexpr expect_value_receiver_ex(T& dest)
: dest_(&dest) {
}

Expand All @@ -227,7 +227,7 @@ namespace {
, env_(std::move(env)) {
}

void set_value(T val) noexcept {
constexpr void set_value(T val) noexcept {
*dest_ = val;
}

Expand All @@ -244,7 +244,7 @@ namespace {
FAIL_CHECK("set_error called on expect_value_receiver_ex");
}

auto get_env() const noexcept -> Env {
constexpr auto get_env() const noexcept -> Env {
return env_;
}
};
Expand Down