-
Notifications
You must be signed in to change notification settings - Fork 635
Cherry pick "Adds dst.dtype information in copy_ method of quantized tensors. #2120" #2673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Zhiyi Su <dantesuu@gmail.com>
Co-authored-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> Signed-off-by: ZhiyiDanielSu <35579247+zobeideThePlayer@users.noreply.github.com>
|
/te-ci L1 pytorch |
Greptile OverviewGreptile SummaryThis PR tweaks The change is contained to Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller as User/Module
participant QT as QuantizedTensor
participant Copy as copy_()
participant PT as torch.Tensor
Caller->>QT: dst.copy_(src)
activate Copy
Copy->>Copy: validate src/dst
Copy->>Copy: determine destination dtype
Copy->>PT: underlying tensor copy (data/scale/metadata)
Copy-->>QT: updated quantized state
deactivate Copy
QT-->>Caller: return dst
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
ksivaman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Creating new PR since the old one for some reason shows merge conflicts and we don't have permissions to update the branch ourselves.
@zobeideThePlayer FYI
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: