Skip to content

Chore: [AEA-0000] - Migrate curl to gh for optimised and robust download #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tstephen-nhs wants to merge 3 commits into from
Closed

Chore: [AEA-0000] - Migrate curl to gh for optimised and robust download #2397

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fcfac5
chore: migrate curl to gh for optised and robust download
tstephen-nhs Feb 16, 2026
179492a
Merge branch 'main' into aea-0000-curl-to-gh
tstephen-nhs Feb 16, 2026
1d4f22d
chore: conditionalise gh auth
tstephen-nhs Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,21 @@ compile: compile-node compile-specification
compile-specification:
npm run compile --workspace packages/specification

download-get-secrets-layer:
gh-auth:
@gh auth status > /dev/null 2>&1 || gh auth login --scopes "read:packages"

gh-auth-ci:
@if [ -z "$$GITHUB_TOKEN" ]; then \
gh auth status > /dev/null 2>&1 || { echo "Error: Not authenticated and GITHUB_TOKEN not set"; exit 1; }; \
fi

download-get-secrets-layer: gh-auth
mkdir -p packages/getSecretLayer/lib
curl -LJ https://github.com/NHSDigital/electronic-prescription-service-get-secrets/releases/download/$$(curl -s "https://api.github.com/repos/NHSDigital/electronic-prescription-service-get-secrets/releases/latest" | jq -r .tag_name)/get-secrets-layer.zip -o packages/getSecretLayer/lib/get-secrets-layer.zip
gh release download \
--repo NHSDigital/electronic-prescription-service-get-secrets \
--pattern 'get-secrets-layer.zip' \
--dir packages/getSecretLayer/lib \
--skip-existing

lint-node: compile-node
npm run lint --workspace packages/capabilityStatement
Expand Down Expand Up @@ -201,7 +213,6 @@ aws-login:
cfn-guard:
./scripts/run_cfn_guard.sh

create-npmrc:
gh auth login --scopes "read:packages"; \
create-npmrc: gh-auth
echo "//npm.pkg.github.com/:_authToken=$$(gh auth token)" > .npmrc
echo "@nhsdigital:registry=https://npm.pkg.github.com" >> .npmrc
Loading