Conversation
| templateStatus: 'NOT_YET_SUBMITTED', | ||
| }); | ||
|
|
||
| const button = screen.getByTestId('send-test-message-button'); |
There was a problem hiding this comment.
nitpicky: you should be able to get this button by accessible role / name. I've seen recently that that's the more idiomatic way where possible, rather than using test ids - https://testing-library.com/docs/queries/about/#priority
| @@ -0,0 +1,40 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
Does this need a be a different component? It's only used once and you're sort of retesting it in the frontend/src/__tests__/components/organisms/PreviewDigitalTemplate.test.tsx
Also, the padding looks a little off from the image on Jira. I can't find this design in the prototype to confirm.
I've previously made src/components/atoms/NHSNotifyWarningCallout/NHSNotifyWarningCallout.tsx, which is used in a few places for this more custom warning callout without the heading. I don't know if that'd do a job here?
4 participants
Description
Adds digital proofing "test message" banner and "Send test message" button to digital template preview pages
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.