CCM-13399 supplier allocation on 12950#408
Open
nhsd-david-wass wants to merge 21 commits intomainfrom
Open
Conversation
nhsd-david-wass
force-pushed
the
feature/CCM-13399-Suppier-Allocation-12950
branch
13 times, most recently
from
a01ac1d to
bd8be29
Compare
stevebux
reviewed
Feb 17, 2026
| }; | ||
|
|
||
| export function createDependenciesContainer(): Deps { | ||
| const log = pino(); |
Contributor
There was a problem hiding this comment.
As part of my recent logging ticket, I added a method to create a pino logger with slightly nicer formatting than you get from the default constructor. Take a look at the deps.ts for any of the other lambdas to see how to bring it in as a dependency
| return "unknown"; | ||
| } | ||
|
|
||
| function parseQueueMessage(queueMessage: string): any { |
Contributor
There was a problem hiding this comment.
I'd be tempted to infer a type from QueueMessageSchema, then this method could return a strongly-typed value.
nhsd-david-wass
force-pushed
the
feature/CCM-13399-Suppier-Allocation-12950
branch
from
5afdd13 to
e0530d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.