Skip to content

Ppha 588 create the review environment and pr trigger#282

Open
mrlockstar wants to merge 11 commits intomainfrom
PPHA-588-Create-the-Review-environment-and-pr-trigger
Open

Ppha 588 create the review environment and pr trigger#282
mrlockstar wants to merge 11 commits intomainfrom
PPHA-588-Create-the-Review-environment-and-pr-trigger

Conversation

@mrlockstar
Copy link
Contributor

What is the change?

Why are we making this change?

@mrlockstar mrlockstar force-pushed the PPHA-588-Create-the-Review-environment-and-pr-trigger branch from 7bb65f7 to 633e540 Compare February 16, 2026 10:48

- name: Call deployment pipeline
run: |
if [[ -n "${{inputs.pr_number}}" ]]; then

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
- name: Call deployment pipeline
run: |
if [[ -n "${{inputs.pr_number}}" ]]; then
pr_argument="prNumber=${{inputs.pr_number}}"

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud

echo "Starting Azure devops pipeline \"Deploy to Azure - ${{ matrix.environment }}\"..."
RUN_ID=$(az pipelines run \
--commit-id ${{inputs.commit_sha}} \

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
--name "Deploy to Azure - ${{ matrix.environment }}" \
--org https://dev.azure.com/nhse-dtos \
--project lung-cancer-risk-check \
--parameters commitSHA=${{inputs.commit_sha}} ${pr_argument} environment=${{ matrix.environment }} pool=${ADO_MANAGEMENT_POOL} \

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
run: |
dns_zone_name=$( grep dns_zone_name infrastructure/environments/${{ matrix.environment }}/variables.tfvars | awk -F'"' '{print $2}' )
use_apex_domain=$( grep use_apex_domain infrastructure/environments/${{ matrix.environment }}/variables.tfvars | awk '{print $3}' || echo "false" )
scripts/bash/container_app_smoke_test.sh "${{ matrix.environment }}" "${{ inputs.commit_sha }}" "${dns_zone_name}" "${{inputs.pr_number}}" "${use_apex_domain}"

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
run: |
dns_zone_name=$( grep dns_zone_name infrastructure/environments/${{ matrix.environment }}/variables.tfvars | awk -F'"' '{print $2}' )
use_apex_domain=$( grep use_apex_domain infrastructure/environments/${{ matrix.environment }}/variables.tfvars | awk '{print $3}' || echo "false" )
scripts/bash/container_app_smoke_test.sh "${{ matrix.environment }}" "${{ inputs.commit_sha }}" "${dns_zone_name}" "${{inputs.pr_number}}" "${use_apex_domain}"

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments