Skip to content

Replace obsolete Request package with Axios in test-suite/client#405

Merged
MartinWheelerMT merged 1 commit intomainfrom
replace-request-in-test-suite-client
Jan 8, 2026
Merged

Replace obsolete Request package with Axios in test-suite/client#405
MartinWheelerMT merged 1 commit intomainfrom
replace-request-in-test-suite-client

Conversation

@MartinWheelerMT
Copy link
Collaborator

@MartinWheelerMT MartinWheelerMT commented Jan 8, 2026

What

  • The Request package is installed in test-suite/client but is not used. This removes the packages and updates package.json and package-lock.json accordingly

Why

Request npm package was marked as obsolete a good number of years ago, and is no longer maintained (see request/request#3142). This package represents a critical security risk due to multiple transitive dependencies it introduces, such as form-data:

image

This needs to be replaced with a maintained package, in this case axios, to ensure critical vulnerabilities are not exposed.

Type of change

Please delete options that are not relevant.

  • Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation where required
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change affects end users.

* The `Request` package is installed in `test-suite\client` but is not used. This removes the packages and updates `package.json` and `package-lock.json` accordingly
@MartinWheelerMT MartinWheelerMT requested a review from a team as a code owner January 8, 2026 15:59
@MartinWheelerMT MartinWheelerMT enabled auto-merge (squash) January 8, 2026 16:01
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Images built and published to ECR using a Build Id of PR-270-a3eaf76

@MartinWheelerMT MartinWheelerMT merged commit 79a36c1 into main Jan 8, 2026
8 checks passed
@MartinWheelerMT MartinWheelerMT deleted the replace-request-in-test-suite-client branch January 8, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments