New: [ELI-418] - Performance tests by Karthikeyannhs · Pull Request #128 · NHSDigital/eligibility-signposting-api-regression-tests

Karthikeyannhs · 2026-02-10T14:49:20Z

Summary

Remove items from this list if they are not relevant. Remove this line once this has been done

Routine Change
❗ Breaking Change
🤖 Operational or Infrastructure Change
✨ New Feature
⚠️ Potential issues that might be caused by this change

Details

Add any summary information of what is in the change. Remove this line if you have nothing to add.

Pull Request Naming

Pull requests should be named using the following format:

Tag: [ELI-NNNN] - Short description

Tag can be one of:

Fix - for a bug fix. (Patch release)
Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems. (Patch release)
New - implemented a new feature. (Minor release)
Breaking - for a backwards-incompatible enhancement or feature. (Major release)
Docs - changes to documentation only. (Patch release)
Build - changes to build process only. (No release)
Upgrade - for a dependency upgrade. (Patch release)
Chore - for refactoring, adding tests, etc. (anything that isn't user-facing). (Patch release)

If the current release is x.y.z then

a patch release increases z by 1
a minor release increases y by 1
a major release increases x by 1

Correct tagging is necessary for our automated versioning and release process (Release).

The description of your pull request will be used as the commit message for the merge, and also be included in the changelog. Please ensure that your title is sufficiently descriptive.

Rerunning Checks

If you need to rename your pull request, you can restart the checks by either:

Closing and reopening the pull request

pushing an empty commit

git commit --allow-empty -m 'trigger build'
git push

Amend your last commit and force push to the branch
```
git commit --amend --no-edit
git push --force
```

Rerunning the checks from within the pull request will not use the updated title.

…uct-ID and associat… (#123) * changes to update nhsd-application-id to NHSE-Product-ID and associated MV and NBS product ids * datahelper fix..dont convert to lower!

* initial push * initial push * nbs files * All TCs NBS RSV TCs and some amendments to the NHS numbers of the COVID scenarios * All TCs NBS RSV TCs and some amendments to the NHS numbers of the COVID scenarios

allow the consumer mapping config in preprod

Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Commits](actions/checkout@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: adam-wallernhs1 <176666249+adam-wallernhs1@users.noreply.github.com>

Bumps [npm](https://github.com/npm/cli) from 11.6.2 to 11.6.3. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](npm/cli@v11.6.2...v11.6.3) --- updated-dependencies: - dependency-name: npm dependency-version: 11.6.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: adam-wallernhs1 <176666249+adam-wallernhs1@users.noreply.github.com>

Bumps [asdf-vm/actions](https://github.com/asdf-vm/actions) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/asdf-vm/actions/releases) - [Changelog](https://github.com/asdf-vm/actions/blob/master/CHANGELOG.md) - [Commits](asdf-vm/actions@1902764...b7bcd02) --- updated-dependencies: - dependency-name: asdf-vm/actions dependency-version: 4.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: eddalmond1 <102675624+eddalmond1@users.noreply.github.com>

TOEL2 · 2026-02-10T16:46:08Z

.github/workflows/performance_tests.yml

+name: Performance Tests
+
+concurrency:
+  group: ${{ github.workflow }}


Are we only ever planning to run these tests in preprod? I ask this because if we wanted to run tests in multiple environments at the same time then this concurrency setting would prevent this.

* Upgrade: [dependabot] - bump boto3 from 1.40.50 to 1.40.62 Bumps [boto3](https://github.com/boto/boto3) from 1.40.50 to 1.40.62. - [Release notes](https://github.com/boto/boto3/releases) - [Commits](boto/boto3@1.40.50...1.40.62) --- updated-dependencies: - dependency-name: boto3 dependency-version: 1.40.62 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * bugfix - trying to fix ci/cd by pinning node version * bugfix - forcing npm version via make command * bugfix - regenerated lockfile locally * removing unneeded pin --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Edd Almond <102675624+eddalmond1@users.noreply.github.com>

* multiple iterations in a single config * updated the My Vaccines RSV config to v1.2 at their request

… after test runs (#130) * updated make file to include the upload of the integration test configs added the locations of the current int test configs in test_config.py updated upload_configs_to_s3 to allow full file paths in the arguments so the above could be passed * updated make file to include the upload of the integration test configs added the locations of the current int test configs in test_config.py updated upload_configs_to_s3 to allow full file paths in the arguments so the above could be passed * updated make file to include the upload of the integration test configs added the locations of the current int test configs in test_config.py updated upload_configs_to_s3 to allow full file paths in the arguments so the above could be passed * updated the My Vaccines RSV config to v1.2 at their request

Signed-off-by: Karthikeyannhs <174426205+Karthikeyannhs@users.noreply.github.com>

TOEL2 · 2026-02-10T16:55:32Z

.github/workflows/performance_tests.yml

+        required: true
+        default: "dev"
+      github_tag:
+        description: 'The github tag to run the test pack from'


I'm a bit conflicted on if we should allow performance tests to be run from a different branch to main. Main has at least some sort of version tagging that we could refer back to that would help us identify exactly which version of the performance tests yielded a given result. I guess if you kept the branch around you could still do that but usually we delete branches after merging.

TOEL2 · 2026-02-10T17:13:46Z

.github/workflows/performance_tests.yml

+          ref: ${{ inputs.github_tag }}
+
+      # using git commit sha for version of action to ensure we have stable version
+      - name: Install asdf


Are we using more than just python in this repo - or more specifically in this workflow? If not it might be simpler to just install python directly here

TOEL2 · 2026-02-10T17:25:23Z

tests/performance_tests/test_performance_tests.py

+        "tests/performance_tests/locust.py",
+        "--headless",
+        "-u",
+        "10",


could we potentially expose these variables - particularly spawn rate and total users - to the workflow dispatch action? We could obviously impose limits on it but would allow us to run different types of tests without changing the code

adam-wallernhs1 and others added 19 commits February 5, 2026 13:07

initial push

43305f0

performance tests initial commit

0665cf7

Chore: [ELI-605] - Changes to update nhsd-application-id to NHSE-Prod…

640ee00

…uct-ID and associat… (#123) * changes to update nhsd-application-id to NHSE-Product-ID and associated MV and NBS product ids * datahelper fix..dont convert to lower!

pytest integrated with performance tests

e5d2802

locust updated

c67004e

fixed the test cases

68d6c4f

added test data

4471fe6

temp file for nhs numbers

266f4bf

fix

c73a920

html output

524c16f

performance test workflow

234a2fd

test performance

0b5754b

added locust to poetry

e15455f

certs file creation for performance tests

a105e09

report.html as artifact

5b2b554

reused eligibility client

7a28e4d

linting

156ba77

formating

293db37

workflow updated

09e396c

Karthikeyannhs requested a review from a team as a code owner February 10, 2026 14:49

adam-wallernhs1 and others added 5 commits February 10, 2026 14:50

Chore: [ELI-592] - NBS COVID Scenarios (#124)

dde4459

* initial push * initial push * nbs files * All TCs NBS RSV TCs and some amendments to the NHS numbers of the COVID scenarios * All TCs NBS RSV TCs and some amendments to the NHS numbers of the COVID scenarios

Chore: [ELI-9875] - allow the consumer mapping config in preprod (#125)

bd14463

allow the consumer mapping config in preprod

Karthikeyannhs had a problem deploying to dev February 10, 2026 14:51 — with GitHub Actions Failure

Merge branch 'main' into performance-testing-spike

8e8e065

Karthikeyannhs had a problem deploying to dev February 10, 2026 14:52 — with GitHub Actions Failure

Karthikeyannhs changed the title ~~Performance testing spike~~ New: [ELI-418] - Performance tests Feb 10, 2026

Karthikeyannhs had a problem deploying to dev February 10, 2026 15:03 — with GitHub Actions Failure

Karthikeyannhs had a problem deploying to dev February 10, 2026 15:21 — with GitHub Actions Failure

TOEL2 reviewed Feb 10, 2026

View reviewed changes

Karthikeyannhs temporarily deployed to dev February 10, 2026 18:40 — with GitHub Actions Inactive

Karthikeyannhs force-pushed the performance-testing-spike branch from 520eac5 to a08befd Compare February 10, 2026 18:47

dependabot bot and others added 5 commits February 10, 2026 18:49

Chore: [ELI-632] - multiple iterations with new text (#129)

eaafc5b

* multiple iterations in a single config * updated the My Vaccines RSV config to v1.2 at their request

poetry lock

052e320

Merge branch 'main' into performance-testing-spike

8190894

Signed-off-by: Karthikeyannhs <174426205+Karthikeyannhs@users.noreply.github.com>

Karthikeyannhs had a problem deploying to dev February 10, 2026 18:58 — with GitHub Actions Failure

poetry lock

45368af

Karthikeyannhs temporarily deployed to dev February 10, 2026 19:11 — with GitHub Actions Inactive

TOEL2 reviewed Feb 11, 2026

View reviewed changes

fixed locust error report

8236f11

Karthikeyannhs had a problem deploying to dev February 11, 2026 11:48 — with GitHub Actions Failure

headers from csv

86301c7

Karthikeyannhs had a problem deploying to dev February 11, 2026 13:52 — with GitHub Actions Failure

removed hardcodings

18defe2

Karthikeyannhs temporarily deployed to dev February 11, 2026 14:23 — with GitHub Actions Inactive

assert based on response time

dc4b552

Karthikeyannhs temporarily deployed to dev February 11, 2026 15:04 — with GitHub Actions Inactive

TOEL2 added 2 commits February 13, 2026 15:21

example log query

f743177

WIP

976703a

TOEL2 temporarily deployed to dev February 17, 2026 11:39 — with GitHub Actions Inactive

WIP

732602c

TOEL2 temporarily deployed to dev February 17, 2026 11:49 — with GitHub Actions Inactive

WIP output html for performance tests.

1b6fe48

ayeshalshukri1-nhs temporarily deployed to dev February 17, 2026 12:14 — with GitHub Actions Inactive

WIP refactor metrics and added basic html table output.

08fe8f0

ayeshalshukri1-nhs temporarily deployed to dev February 17, 2026 16:56 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New: [ELI-418] - Performance tests#128

New: [ELI-418] - Performance tests#128
Karthikeyannhs wants to merge 44 commits intomainfrom
performance-testing-spike

Karthikeyannhs commented Feb 10, 2026

Uh oh!

TOEL2 Feb 10, 2026

Uh oh!

TOEL2 Feb 10, 2026

Uh oh!

TOEL2 Feb 10, 2026

Uh oh!

TOEL2 Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Karthikeyannhs commented Feb 10, 2026

Summary

Details

Pull Request Naming

Rerunning Checks

Uh oh!

TOEL2 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

TOEL2 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

TOEL2 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

TOEL2 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants