Conversation
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Image Scan SummaryImage: 900119715266.dkr.ecr.eu-west-2.amazonaws.com/whoami:feature-gpcapim-258-sds-access-module
Findings (top 50)
|
|
✅ Trivy gate: no Critical/High issues. Trivy IaC (Terraform) Summary
Findings (top 50)
|
| # URLs for different SDS environments | ||
| SANDBOX_URL = "https://sandbox.api.service.nhs.uk/spine-directory/FHIR/R4" | ||
| INT_URL = "https://int.api.service.nhs.uk/spine-directory/FHIR/R4" | ||
| DEP_UAT_URL = "https://dep.api.service.nhs.uk/spine-directory/FHIR/R4" | ||
| PROD_URL = "https://api.service.nhs.uk/spine-directory/FHIR/R4" |
There was a problem hiding this comment.
I can see that these might be useful long-term, but are they adding value at this point?
There was a problem hiding this comment.
Is there any benefit to removing them? There's no test overhead or anything, and it means as and when later on we want to add them in we don't have to go looking for the addresses or make code changes to be able to handle them.
There was a problem hiding this comment.
(And we'll want at least sandbox and int retained anyway, won't we?)
There was a problem hiding this comment.
Agreed - happy to leave for now.
Vox-Ben
force-pushed
the
feature/GPCAPIM-258_SDS_access_module
branch
from
11f8a33 to
db8aa1c
Compare
DWolfsNHS
left a comment
DWolfsNHS
left a comment
There was a problem hiding this comment.
Approving for code review, given that this can't merge until the pipeline passes which is pending @neil-sproston implementing a terraform fix.
|
|
Deployment Complete
|
3 participants
Description
Creates the SDS access module and integrates it with the controller.
Context
CDG requires the ability to obtain organisation ASIDs and endpoints from SDS. This provides that capability.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.