Conversation
…ocal or global location.
- refactored install workflow to promot user for preferred neo.express location
- added logging
…it's the right place
- refactored code - updated neoExpress to call neoxp based on package location
- removed axios as a depend - refactored installer code
…ed any of such tests yet. Adding unit tests as a starter
JohndeVadoss
approved these changes
Jan 25, 2023
devhawk
reviewed
Jan 26, 2023
devhawk
reviewed
Jan 26, 2023
devhawk
reviewed
Jan 26, 2023
devhawk
reviewed
Jan 26, 2023
devhawk
reviewed
Jan 26, 2023
devhawk
reviewed
Jan 26, 2023
…st. It costly(install/uninstall/impacts overall sytem with global option) to test installer code with integration test
…th jest packages. for now ping the version to 4.6.3. We will have to revist this.
ERROR in ./src/extension/index.ts
Module build failed (from ./node_modules/ts-loader/index.js):
Error: Debug Failure. False expression: Non-string value passed to `ts.resolveTypeReferenceDirective`, likely by a wrapping package working with an outdated `resolveTypeReferenceDirectives` signature. This is probably not a problem in TS itself.
at Object.resolveTypeReferenceDirective (/Users/weijie/code/neo/neo3-visual-tracker/node_modules/typescript/lib/typescript.js:42530:18)
at /Users/weijie/code/neo/neo3-visual-tracker/node_modules/ts-loader/dist/servicesHost.js:679:18
at /Users/weijie/code/neo/neo3-visual-tracker/node_modules/ts-loader/dist/servicesHost.js:118:141
at Array.map (<anonymous>)
at Object.resolveTypeReferenceDirectives (/Users/weijie/code/neo/neo3-visual-tracker/node_modules/ts-loader/dist/servicesHost.js:118:124)
at actualResolveTypeReferenceDirectiveNamesWorker (/Users/weijie/code/neo/neo3-visual-tracker/node_modules/typescript/lib/typescript.js:116611:163)
at resolveTypeReferenceDirectiveNamesWorker (/Users/weijie/code/neo/neo3-visual-tracker/node_modules/typescript/lib/typescript.js:116911:26)
at processTypeReferenceDirectives (/Users/weijie/code/neo/neo3-visual-tracker/node_modules/typescript/lib/typescript.js:118393:31)
at findSourceFileWorker (/Users/weijie/code/neo/neo3-visual-tracker/node_modules/typescript/lib/typescript.js:118278:21)
at findSourceFile (/Users/weijie/code/neo/neo3-visual-tracker/node_modules/typescript/lib/typescript.js:118133:26)
webpack 5.37.0 compiled with 1 error in 1100 ms
…low user to specify the version to install
devhawk
reviewed
Jan 30, 2023
devhawk
reviewed
Jan 30, 2023
devhawk
reviewed
Jan 30, 2023
devhawk
reviewed
Jan 30, 2023
devhawk
reviewed
Jan 30, 2023
devhawk
reviewed
Jan 30, 2023
devhawk
reviewed
Jan 30, 2023
…l deal with the error object automatically
- added don't show again for neo.express location selection - added force check function don't show again variables are skipped. This is used when user calls install/update from the command pallate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing neo.express from the extension bundle and using the neo.express from local or global instead. This reduces the extension package from 27M to about 700KB.