refactor: DNS backend by iyashnov · Pull Request #876 · MultiDirectoryLab/MultiDirectory

iyashnov · 2025-12-24T06:29:41Z

Задачи: 1057, 1058

Произведена замена DNS сервера с Bind9 на PowerDNS, состоящий из двух компонентов: Authoritative Server и Recursor. Произведен рефакторинг компонентов DNS сервера. Вся логика, относящаяся к Bind9, была удалена, за исключением некоторым датаклассов по просьбе Егора. Вся логика была воспроизведена в соответствии с новым DNS сервером за исключением пары фич: включение/отключение DNSSEC опции DNS сервера - теперь это опция относится к зоне, соответственно, временно удален функционал получения и изменения параметров DNS сервера, удалена возможность перезагружать DNS сервер и отдельную зону, так как в этом больше нет необходимости и на фронт этот функционал так и не был выведен.

Сделано:

Добавлен Dockerfile для сборки образа с PowerDNS Authoritative Server поддерживающим LMDB бэкенд
Заменены компоненты Bind9 на PowerDNS в docker-compose
Удалено самописное API для Bind9 и все файлы, связанные со сборкой образа под него
Удален менеджер Selfhosted, который относился к Bind9
Добавлен менеджер для работы с PowerDNS
Переработаны роутер и адаптер FastAPI, требуется доработка фронта
Добавлены отдельные ручки для управления forward зонами
Настройка разделена на 2 этапа: смена состояния и, соответственно, настройка согласно состоянию
Доработаны тесты

UPD: Добавлен dnsdist

Добавлен dnsdist в докер композ
Добавлен клиент для управления
Добавлена генерация ключей для API

Copilot

Pull request overview

This PR refactors the DNS backend from Bind9 to PowerDNS, implementing a two-component architecture with PowerDNS Authoritative Server and Recursor. The refactoring involves significant changes to the DNS management layer, API endpoints, and configuration.

Key changes:

Migration from Bind9 to PowerDNS with custom Dockerfile for LMDB backend support
Removal of self-hosted Bind9 manager and custom DNS API
Introduction of new DTOs and enums aligned with PowerDNS data structures
API restructuring with zone_id as path parameters and separate endpoints for forward zones
Removal of DNS server-level configuration endpoints (DNSSEC now zone-specific)

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
pdns.conf	PowerDNS Authoritative Server configuration with LMDB backend
recursor.conf	PowerDNS Recursor configuration with API access
.docker/pdns_auth.Dockerfile	Alpine-based build for PowerDNS with LMDB support
docker-compose.yml	Replaced bind_dns service with pdns_auth and pdns_recursor services
app/ldap_protocol/dns/powerdns.py	New PowerDNS manager implementing AbstractDNSManager interface
app/ldap_protocol/dns/dto.py	Extended DTOs for PowerDNS zones, records, and RRSets
app/ldap_protocol/dns/enums.py	New enums for DNS record types, zone types, and change types
app/api/main/dns_router.py	Restructured routes with zone_id path params and forward zone endpoints
app/api/main/adapters/dns.py	Adapter updated to construct DTOs from request schemas
app/ldap_protocol/dns/use_cases.py	Simplified use cases with removed server options functionality
app/config.py	New config for PDNS hosts and API key
app/ioc.py	Updated DI container for PowerDNS client provisioning
tests/test_api/test_main/test_dns.py	Comprehensive test updates for new API structure

Comments suppressed due to low confidence (1)

app/ldap_protocol/dns/stub.py:77

This method requires 2 positional arguments, whereas overridden AbstractDNSManager.check_forward_dns_server requires 3.

    @logger_wraps(is_stub=True)
    async def check_forward_dns_server(
        self,
        dns_server_ip: str,

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-24T08:33:58Z

app/ldap_protocol/dns/use_cases.py

+    async def delete_zones(self, zone_ids: list[str]) -> None:
+        """Delete DNS zones."""
+        for zone_id in zone_ids:
+            await self._dns_manager.delete_zone(zone_id)


The use_cases.py delete_zones method iterates through zone_ids and calls delete_zone for each one. If any of these calls fail, the remaining zones won't be deleted. Consider implementing error handling to either collect errors and raise them at the end, or use a transaction-like mechanism to ensure all-or-nothing deletion.

app/ldap_protocol/dns/powerdns.py

app/api/main/adapters/dns.py

Copilot · 2025-12-24T08:33:59Z

.package/recursor.conf

@@ -0,0 +1,10 @@
+local-address=0.0.0.0
+webserver-allow-from=0.0.0.0/0


The webserver is configured to allow connections from any IP address (0.0.0.0/0). This is a security risk in production environments. Consider restricting access to specific IP ranges or implementing additional authentication mechanisms.

Suggested change

webserver-allow-from=0.0.0.0/0

webserver-allow-from=127.0.0.1/32

Пока сделано так, в дальнейшем, при добавлении PowerDNS DNSdist будет переделано.

Copilot · 2025-12-24T08:33:59Z

.package/pdns.conf

+local-port=53
+api=yes
+api-key=supersecretapikey
+webserver-allow-from=0.0.0.0/0


The webserver is configured to allow connections from any IP address (0.0.0.0/0). This is a security risk in production environments. Consider restricting access to specific IP ranges or implementing additional authentication mechanisms.

Suggested change

webserver-allow-from=0.0.0.0/0

webserver-allow-from=127.0.0.1,::1

Здесь то же самое

app/ldap_protocol/dns/__init__.py

app/ldap_protocol/dns/powerdns.py

.package/pdns.conf

Copilot · 2025-12-24T08:34:00Z

recursor.conf

+webserver=yes
+webserver-address=0.0.0.0
+webserver-port=8083
+api-key=supersecretapikey


The API key "supersecretapikey" is hardcoded in the configuration file. This is a security risk as it exposes the API key in version control. The API key should be passed as an environment variable or mounted from a secrets management system.

Suggested change

api-key=supersecretapikey

api-key=changeme # real value must be injected from environment/secrets at deploy time

То же самое, что и выше.

Copilot · 2025-12-24T08:34:01Z

app/ldap_protocol/dns/use_cases.py

+    async def delete_forward_zones(self, zone_ids: list[str]) -> None:
+        """Delete DNS forward zones."""
+        for zone_id in zone_ids:
+            await self._dns_manager.delete_forward_zone(zone_id)


The same issue exists in delete_forward_zones - if any deletion fails, the remaining zones won't be deleted. Consider implementing error handling to either collect errors and raise them at the end, or use a transaction-like mechanism to ensure all-or-nothing deletion.

app/api/dns/adapter.py

app/api/main/adapters/dns.py

app/ldap_protocol/dns/utils.py

.docker/pdns_auth.Dockerfile

app/api/main/adapters/dns.py

docker-compose.yml

app/ldap_protocol/dns/power_dns_manager.py

docker-compose.yml

app/ldap_protocol/dns/__init__.py

app/ldap_protocol/dns/dns_gateway.py

milov-dmitriy · 2025-12-24T10:14:43Z

app/ldap_protocol/dns/dns_gateway.py

    async def create(self, data: CatalogueSetting) -> None:
        """Create DNS."""
        self._session.add(data)
        await self._session.commit()


на уровне gateway мы можем делать commit? по моему на таком низком уровне мы договаривались без коммита, а только flush

т.к. если тут сделать коммит, то транзакция закроется и мы не сможем собрать пайплайн из двух небольших методов гейтвея (если в каждом из них будет по коммиту), тк первый метод закроет транзакцию

Нужна помощь второго ревьювера, не берусь утверждать

в manager/use_case/service есть коммит
гейтвей как и dao как и репозиторий примерно одно и то же с нюансами, но все инкапсулирует доступ к данным, поэтому там коммита нет, чтобы можно было легко собрать любой пайплайн из этих методов, как из кирпичиков и транзакция не закрылась по середине

Дима прав. Егор говорил, что мы управляем сессией на уровне use_case не gateway. Т.к. задача gateway работать с данными, а когда их отнести до БД, решается выше уровнем

Misha-Shvets · 2025-12-24T11:23:36Z

app/ldap_protocol/dns/exceptions.py

    code = ErrorCodes.DNS_NOT_IMPLEMENTED_ERROR
+
+
+class DNSUnavailableError(DNSError):


если какая-то из ошибок идет на фронт, нужно добавить код в enum выше. так же добавить в error_map ее, чтобы она обрабатывалась в роуте

Эта ошибка не идет на фронт, но добавил другие

app/ldap_protocol/dns/power_dns_manager.py

Misha-Shvets · 2025-12-24T11:35:16Z

app/ldap_protocol/dns/power_dns_manager.py

+base_retort = Retort()
+
+
+class PowerDNSManager(AbstractDNSManager):


как по мне, получился уберкомбайнер, который шлет\валидирует запросы(работа с http), логика самого днс, вычисление и агрегация данных. ИМХО слишком много всего, я бы декомпозировал

Согласен, но предлагаю отложить пока

Misha-Shvets · 2025-12-24T11:46:26Z

а мы от адаптикса отказались, почему все дто вручную?

iyashnov · 2025-12-24T11:47:35Z

а мы от адаптикса отказались, почему все дто вручную?

Потому что пытался по минимуму менять схемы фронтовые, чтобы меньше фронтам переделывать

Misha-Shvets · 2025-12-24T11:52:40Z

а мы от адаптикса отказались, почему все дто вручную?

Потому что пытался по минимуму менять схемы фронтовые, чтобы меньше фронтам переделывать

так адаптикс просто код перевода объектов убирает из логики, схему фронтовые можно не менять

milov-dmitriy

от души

app/ldap_protocol/dns/dns_gateway.py

app/ldap_protocol/dns/exceptions.py

app/ldap_protocol/dns/power_dns_manager.py

app/ldap_protocol/dns/powerdns.py

app/ldap_protocol/dns/constants.py

app/ioc.py

milov-dmitriy

ничего существенного только нейминг
я бы в будущем посмотрел в сторону рефакторинга app/ldap_protocol/dns, хотелось бы сгруппировать логические блоки кода между собой, например всех менеджеров в одну кучу, все Enum положить в одно место, нужно уменьшить кол-во разных сущностей в base, по итогу получится в лучших традициях high cohesion/low coupling

milov-dmitriy · 2026-01-20T12:08:39Z

.package/docker-compose.yml

+      - ./recursor.conf:/etc/powerdns/recursor.conf
+      - forward_zones:/etc/powerdns/recursor.d/
+
+  pdnsdist:


pdns_dist ? стоит в едином стиле делать?

или так принято

Официально оно просто dnsdist называется

app/api/main/adapters/dns.py

app/api/main/schema.py

milov-dmitriy · 2026-01-20T13:01:17Z

app/ldap_protocol/dns/power_dns_manager.py

+base_retort = Retort()
+
+
+class PowerDNSDistClient:


предлагаю согласовать названия файла и класса:
power_dns_manager.py‎ < - > PowerDNSDistClient

а что значит Dist?

думаю, что было бы яснее, если мы бы смогли более явно указать, что значит remote_dns_manager. указать его отличие от других dns менеджеров если они есть (судя по названию вроде как должны быть)
т.е. предполагается что

есть не только remote? но и local?
или

remote client и local client?

Remote DNS manager - унифицированный менеджер для DNS'a клиента, который может только записями управлять
Хз, как его еще обозвать

app/ldap_protocol/dns/managers/stub_dns_manager.py

app/ioc.py

.package/dnsdist.conf

rimu-stack · 2026-01-20T15:22:51Z

app/config.py

+    PDNS_AUTH_SERVER_HOST: str = "pdns_auth"
+    PDNS_AUTH_SERVER_IP: str = "172.20.0.4"
+    PDNS_AUTH_SERVER_PORT: int = 8082
+    PDNS_RECURSOR_SERVER_HOST: str = "pdns_recursor"
+    PDNS_RECURSOR_SERVER_IP: str = "172.20.0.2"
+    PDNS_RECURSOR_SERVER_PORT: int = 8083
+    PDNS_DIST_HOST: str = "172.20.0.3"
+    PDNS_DIST_PORT: int = 8084
+    PDNS_DIST_CONFIG_PATH: str = "/dnsdist/delta.conf"
+    PDNS_DIST_KEY: str
+    PDNS_API_KEY: str
+    DEFAULT_NAMESERVER: str


добавить описание в вики

app/ioc.py

app/ldap_protocol/dns/base.py

app/ldap_protocol/dns/power_dns_manager.py

app/ldap_protocol/dns/use_cases.py

resolv.conf

…port

…agement and error handling

…ed DTOs

…dates

…kages

…or PowerDNS

…nses

…te resolv.conf file

Copilot

Pull request overview

Copilot reviewed 60 out of 63 changed files in this pull request and generated 14 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-04T08:51:37Z

app/ldap_protocol/dns/clients/power_dnsdist_client.py

+            rules = self._get_all_rules()
+            if not rules.count:
+                DNSdistError(
+                    "Failed to delete existing rule in dnsdist: Not Found",
+                )
+


In remove_zone_rule, the DNSdistError(...) is instantiated but never raised when no rules are found, so the failure is silently ignored. This can leave stale routing rules in place without surfacing an error. Raise the exception (or otherwise handle the not-found case explicitly).

Copilot · 2026-02-04T08:51:38Z

app/ldap_protocol/dns/clients/abstract_client.py

+    async def _validate_response(self, response: httpx.Response) -> None:
+        """Validate the API response."""
+        match response.status_code:
+            case status.HTTP_400_BAD_REQUEST:
+                raise DNSNotSupportedError(response.text or "Bad Request")
+            case status.HTTP_404_NOT_FOUND:
+                raise DNSEntryNotFoundError(response.text or "Not Found")
+            case status.HTTP_422_UNPROCESSABLE_ENTITY:
+                raise DNSValidationError(
+                    response.text or "Unprocessable Entity",
+                )
+            case status.HTTP_500_INTERNAL_SERVER_ERROR:
+                raise DNSUnavailableError(
+                    response.text or "Internal Server Error",
+                )
+


AbstractDNSHTTPClient._validate_response() only raises for a small set of status codes (400/404/422/500) and silently treats other failures (e.g., 401/403/409/429/502/503) as success. This can cause callers to proceed on error responses. Consider raising on any response.is_error (or add a default case _ that raises a suitable DNSError for unhandled 4xx/5xx).

Copilot · 2026-02-04T08:51:38Z

app/ldap_protocol/dns/use_cases.py

+    async def get_status(self) -> dict[str, str | None]:
        """Get DNS status."""
        return {
-            "dns_status": await self._dns_gateway.get_dns_state(),
-            "zone_name": self._dns_settings.zone_name,
-            "dns_server_ip": self._dns_settings.dns_server_ip,
+            "dns_status": await self._dns_gateway.get_state(),
+            "zone_name": self._dns_settings.domain,
+            "dns_server_ip": str(self._dns_settings.dns_server_ip),
        }


get_status() always stringifies self._dns_settings.dns_server_ip, so when it is None the API returns the literal string "None" even though the return type is str | None. Return None when the value is missing to keep the response contract consistent.

Copilot · 2026-02-04T08:51:38Z

.docker/pdns_auth.Dockerfile

+      --with-unixodbc-lib=/usr/lib/$(dpkg-architecture -q DEB_BUILD_GNU_TYPE) && \
+    make clean && \
+    make $MAKEFLAGS -C ext &&\
+    make $MAKEFLAGS -C modules &&\
+    make $MAKEFLAGS -C pdns && \
+    make -C pdns install DESTDIR=/build &&\ 
+    make -C modules install DESTDIR=/build &&\ 


The build stage uses $(dpkg-architecture -q DEB_BUILD_GNU_TYPE) inside an Alpine image; dpkg-architecture is not available on Alpine by default, so this Dockerfile will fail to build. Also, the lines &&\ (backslash followed by a space) will break shell line-continuation and can cause a syntax error. Remove the dpkg-architecture usage (or install the needed tool) and fix the trailing whitespace after \ in the RUN command.

Suggested change

--with-unixodbc-lib=/usr/lib/$(dpkg-architecture -q DEB_BUILD_GNU_TYPE) && \

make clean && \

make $MAKEFLAGS -C ext &&\

make $MAKEFLAGS -C modules &&\

make $MAKEFLAGS -C pdns && \

make -C pdns install DESTDIR=/build &&\

make -C modules install DESTDIR=/build &&\

--with-unixodbc-lib=/usr/lib && \

make clean && \

make $MAKEFLAGS -C ext &&\

make $MAKEFLAGS -C modules &&\

make $MAKEFLAGS -C pdns && \

make -C pdns install DESTDIR=/build &&\

make -C modules install DESTDIR=/build &&\

Copilot · 2026-02-04T08:51:38Z

app/ldap_protocol/dns/utils.py

+log = logger.bind(name="DNSManager")
+
+log.add(
+    "logs/dnsmanager_{time:DD-MM-YYYY}.log",
+    filter=lambda rec: rec["extra"].get("name") == "dnsmanager",
+    retention="10 days",
+    rotation="1d",
+    colorize=False,
+)


The log sink filter checks rec["extra"].get("name") == "dnsmanager", but the logger is bound with name="DNSManager". With the current mismatch, this sink will never receive records. Align the bound name and filter value (and consider ensuring the logs/ directory exists before adding the sink, otherwise Loguru will fail to open the file).

Copilot · 2026-02-04T08:51:40Z

app/ldap_protocol/dns/managers/stub_dns_manager.py

+    @logger_wraps(is_stub=True)
+    async def check_forward_dns_server(
+        self,
+        dns_server_ip: str,
+    ) -> None: ...


StubDNSManager.check_forward_dns_server signature does not match the abstract interface / use-case call site (it should accept (dns_server_ip: IPv4Address|IPv6Address, host_dns_servers: list[str]) and return DNSForwardServerStatus). As-is, DNSUseCase.check_forward_server() will raise TypeError when the Stub manager is used. Update the stub method signature/return type to match AbstractDNSManager.

Copilot · 2026-02-04T08:51:40Z

local.env

+DEFAULT_NAMESERVER=172.20.0.4
+PDNS_API_KEY=supersecretapikey
+PDNS_DIST_KEY=PSAag0AEziPZuBB7kdcfIEkVJOyQInRcBRAhadWDpU0=


local.env now contains PDNS_API_KEY and PDNS_DIST_KEY values committed to the repo. Even if this is “dev only”, it trains users to reuse secrets and risks accidental exposure. Prefer placeholders (e.g., supersecretapikey) and generate real keys via the setup scripts / environment injection, or move these to .env (already gitignored).

Copilot · 2026-02-04T08:51:40Z

.package/resolv.conf

+#
+# macOS Notice
+#
+# This file is not consulted for DNS hostname resolution, address
+# resolution, or the DNS query routing mechanism used by most
+# processes on this system.
+#
+# To view the DNS configuration used by this system, use:
+#   scutil --dns
+#
+# SEE ALSO
+#   dns-sd(1), scutil(8)
+#
+# This file is automatically generated.
+#
+nameserver 192.168.68.1


.package/resolv.conf looks like a machine-generated copy of a developer host’s resolver config (it even contains the macOS autogenerated header and a local nameserver). This should be generated at install time (as setup.sh already does) and gitignored, not committed to the repo.

Copilot · 2026-02-04T08:51:40Z

app/ldap_protocol/dns/managers/remote_dns_manager.py

+    @logger_wraps()
+    async def get_records(self) -> list[DNSRRSetDTO]:
+        """Get all DNS records."""


RemoteDNSManager.get_records is missing the required zone_id parameter (the abstract interface and DNSUseCase.get_records(zone_id) call it with an argument). This will raise TypeError: ... takes 1 positional argument but 2 were given in HOSTED mode. Adjust the method signature to accept zone_id: str (even if unused) to match AbstractDNSManager.

Copilot · 2026-02-04T08:51:41Z

app/ldap_protocol/dns/managers/abstract_dns_manager.py

+    _dns_settings: DNSSettingsDTO
+    _dns_master_client: AbstractDNSMasterHTTPClient | None = None
+    _dns_forward_cient: AbstractDNSForwardHTTPClient | None = None
+


Typo in attribute name: _dns_forward_cient should be _dns_forward_client. Even if unused now, keeping the correct spelling avoids confusion and prevents future bugs when this attribute is referenced.

milov-dmitriy

[опционально]

по-хорошему проверить у всех затронутых файлов шапку: докстринг + год копирайта.

milov-dmitriy · 2026-02-04T08:34:00Z

app/ldap_protocol/dns/clients/power_dnsdist_client.py

+                if "to pool" in line:
+                    matches = pattern.match(line)
+                    if matches:
+                        rules.append(
+                            RuleEntry(
+                                id=int(matches.group(1)),
+                                match=matches.group(2).strip(),
+                                action=matches.group(3).strip(),
+                            ),
+                        )


[опционально]
if "to pool" in line and (matches := pattern.match(line)):

можно так и чуть поменьше отступов будет, поменьше "вложенность"

milov-dmitriy · 2026-02-04T08:37:08Z

app/ldap_protocol/dns/clients/power_dnsdist_client.py

+        command = f"""
+            newServer({{
+                address = "{recursor_ip}:53",
+                pool = "recursor"
+            }})
+        """


смотрю и хочется эти команды унести в отдельный класс, например: DNSdistCommands

сейчас команды выглядят как магические переменные

milov-dmitriy · 2026-02-04T08:37:17Z

app/ldap_protocol/dns/clients/power_dnsdist_client.py

+        """
+        self._send_command(
+            command,
+            expected=DNSdistCommandType.GENERIC,


DNSdistCommandType -> DNSdistCommandTypes ?

milov-dmitriy · 2026-02-04T08:41:28Z

.gitignore

 .installed.cfg
 *.egg
 MANIFEST
+resolve.conf


это нужно?

milov-dmitriy · 2026-02-04T08:55:09Z

app/ldap_protocol/dns/dns_gateway.py

+                    [
+                        DNS_MANAGER_ZONE_NAME,
+                        DNS_MANAGER_IP_ADDRESS_NAME,
+                        DNS_MANAGER_TSIG_KEY_NAME,
+                    ],


[nitpick] лучше вместо списка - кортеж

и лучше in в одну строку с атрибутом, так:

settings = await self._session.scalars( select(CatalogueSetting) .filter( qa(CatalogueSetting.name).in_([ DNS_MANAGER_ZONE_NAME, DNS_MANAGER_IP_ADDRESS_NAME, DNS_MANAGER_TSIG_KEY_NAME, ], ), ), ) # fmt: skip

iyashnov requested a review from Copilot December 24, 2025 08:26

Copilot started reviewing on behalf of iyashnov December 24, 2025 08:27 View session

Copilot AI reviewed Dec 24, 2025

View reviewed changes

milov-dmitriy requested changes Dec 24, 2025

View reviewed changes

milov-dmitriy reviewed Dec 24, 2025

View reviewed changes

app/ldap_protocol/dns/power_dns_manager.py Outdated Show resolved Hide resolved

milov-dmitriy reviewed Dec 24, 2025

View reviewed changes

docker-compose.yml Show resolved Hide resolved

milov-dmitriy requested changes Dec 24, 2025

View reviewed changes

milov-dmitriy requested a review from Misha-Shvets December 24, 2025 10:34

milov-dmitriy assigned milov-dmitriy, iyashnov and Misha-Shvets Dec 24, 2025

milov-dmitriy added python Pull requests that update Python code DNS DNS issues labels Dec 24, 2025

Misha-Shvets requested changes Dec 24, 2025

View reviewed changes

milov-dmitriy requested changes Dec 24, 2025

View reviewed changes

milov-dmitriy approved these changes Dec 24, 2025

View reviewed changes

iyashnov force-pushed the refactor_dns_backend branch from 49664af to 8bd9a0e Compare January 19, 2026 12:59

milov-dmitriy self-requested a review January 20, 2026 12:04

milov-dmitriy requested changes Jan 20, 2026

View reviewed changes

rimu-stack requested changes Jan 20, 2026

View reviewed changes

Misha-Shvets approved these changes Jan 21, 2026

View reviewed changes

iyashnov added 6 commits February 4, 2026 09:50

add: add PowerDNS authoritative and recursor services with Docker sup…

c256de6

…port

refactor: update DNS service adapter and router for improved zone man…

a68dd79

…agement and error handling

refactor: add PDNS_API_KEY to local environment configuration

2b1ea2f

refactor: restructure DNS module with PowerDNS integration and enhanc…

628b37f

…ed DTOs

refactor: update DNS settings and add PowerDNS client support

4fb4e45

refactor: enhance DNS management with PowerDNS integration and DTO up…

f06bc91

…dates

iyashnov added 24 commits February 4, 2026 09:52

add: added unconditional forward DNS to recursor config

557fea9

refactor: removed PDNS recursor from traefik

0744b24

add: added dnsdist client to manage dnsdist

fe23997

add: added dnsdist to prod docker-compose.yml

a31402b

refactor: added api key generation for PDNS

2f1b6d6

add: added windows script to generate DNS API keys

869f13e

fix: codestyle

516238d

add: added libsodium package to test image

cd2494f

fix: changed workflow to build pdns auth image instead of bind for dev

134c1c6

fix: fixed tests

cd6e81c

add: added env to remote docker-compose for tests

066e6f3

refactor: changed API key value to template value in config for prod

32aa746

refactor: clarified variables

ac2bb31

refactor: separated managers from clients and moved to individual pac…

213fe76

…kages

test: fixed tests

73fdc22

refactor: changed method naming for consistency

a017638

refactor: changed module name for clarity

14e2fa6

refactor: added individual methods for every action in HTTP clients f…

d138c25

…or PowerDNS

refactor: unite all DNS record actions in one method

ba7c920

refactor: added logging

b3e5600

refactor: enhance dnsdist client with type hints and structured respo…

019d502

…nses

refactor: separate DNS service with dedicated router and adapter

58a79fe

refactor: update .gitignore to include resolve.conf and remove obsole…

f96ba64

…te resolv.conf file

refactor: improve error handling in zone deletion methods

2c2afb5

iyashnov force-pushed the refactor_dns_backend branch from 7198477 to 2c2afb5 Compare February 4, 2026 06:56

fix: update import paths for DNS adapter and abstract client

1f90a93

milov-dmitriy requested a review from Copilot February 4, 2026 08:34

Copilot started reviewing on behalf of milov-dmitriy February 4, 2026 08:34 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

milov-dmitriy requested changes Feb 4, 2026

View reviewed changes

		@@ -0,0 +1,10 @@
		local-address=0.0.0.0
		webserver-allow-from=0.0.0.0/0

	webserver-allow-from=0.0.0.0/0
	webserver-allow-from=127.0.0.1/32

	webserver-allow-from=0.0.0.0/0
	webserver-allow-from=127.0.0.1,::1

	api-key=supersecretapikey
	api-key=changeme # real value must be injected from environment/secrets at deploy time

		code = ErrorCodes.DNS_NOT_IMPLEMENTED_ERROR


		class DNSUnavailableError(DNSError):

		base_retort = Retort()


		class PowerDNSManager(AbstractDNSManager):

Conversation

iyashnov commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Misha-Shvets commented Dec 24, 2025

Uh oh!

iyashnov commented Dec 24, 2025

Uh oh!

Misha-Shvets commented Dec 24, 2025

Uh oh!

milov-dmitriy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iyashnov commented Dec 24, 2025 •

edited

Loading