Open
Conversation
Signed-off-by: Aleck <aleck@ubersv.com>
github-actions
bot
added
needs triage
zyv
requested changes
Aug 14, 2025
Member
zyv
left a comment
zyv
left a comment
There was a problem hiding this comment.
Thank you for updating this to Boto3 and Futures. After integrating the Python 3 update, we didn't have the time or energy to tackle the Boto3 migration.
Is there an easy way to test this without using AWS credentials before merging?
| handle_client_error('Unable to list buckets', e) | ||
|
|
||
| # Import python timezones (pytz) | ||
| try: |
Member
There was a problem hiding this comment.
Starting with Python 3.9, the standard library includes time zone support. It would be best to try in the following order: 1) the standard library, 2) pytz, and 3) the fallback.
| @@ -1,7 +1,7 @@ | |||
| #! @PYTHON@ | |||
| #!/usr/bin/env python3 | |||
Member
There was a problem hiding this comment.
Please leave it as is. It will be replaced during the build.
Comment on lines
-35
to
-42
| # Settings: (should be set via environment) | ||
| # Required: | ||
| # AWS_ACCESS_KEY_ID : Amazon AWS access key (required) | ||
| # AWS_SECRET_ACCESS_KEY : Amazon AWS secret access key (required) | ||
| # Optional: | ||
| # MCVFS_EXTFS_S3_LOCATION : where to create new buckets: "EU" - default, "USWest", "APNortheast" etc. | ||
| # MCVFS_EXTFS_S3_DEBUGFILE : write debug info to this file (no info by default) | ||
| # MCVFS_EXTFS_S3_DEBUGLEVEL : debug messages level ("WARNING" - default, "DEBUG" - verbose) |
Member
There was a problem hiding this comment.
Could you please leave the settings block and update it to reflect the current state?
zyv
added
area: vfs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
S3 support was outdated and broken
The fix is simply a 2 minutes one by Q dev. Works fine, but surely code review is a must
Checklist
👉 Our coding style can be found here: https://midnight-commander.org/coding-style/ 👈
git commit --amend -smake indent && make check)