Relations and vehicles reference each other#146
Draft
senhalil wants to merge 1 commit intoMapotempo:devfrom
Draft
Relations and vehicles reference each other#146senhalil wants to merge 1 commit intoMapotempo:devfrom
senhalil wants to merge 1 commit intoMapotempo:devfrom
Conversation
senhalil
changed the title
senhalil
force-pushed
the
feat/relation_vehicle_references
branch
from
e165144 to
9e199b6
Compare
senhalil
force-pushed
the
feat/relation_vehicle_references
branch
2 times, most recently
from
64bb971 to
86a85e0
Compare
senhalil
force-pushed
the
feat/relation_vehicle_references
branch
from
86a85e0 to
610ccb0
Compare
Contributor
Author
|
senhalil
force-pushed
the
feat/relation_vehicle_references
branch
from
610ccb0 to
7566d86
Compare
senhalil
force-pushed
the
feat/relation_vehicle_references
branch
from
7566d86 to
01c061b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fonsecadeline I had to remove the vehicle relation from #144 because it is not compatible with the actual multi tour expansion logic. Since the expansion of the
tripparameter is inside the optimizerwrapper and uses Marshal.dump/load thebase.rbcannot "see" these new vehicles and the trip relation generated inside this expansion function cannot point to these vehicles. We need to move the expansion of thevehicle[:trips]before the create function so that inside the code we only maintain one way -- trips as relations.