[newsfeed] refactor: migrate to centralized HTTPFetcher #4023
+108
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates the Newsfeed module to use the centralized HTTPFetcher class introduced in MagicMirrorOrg#4016, following the same pattern as the Calendar module. Changes: - Refactored NewsfeedFetcher from function constructor to ES6 class - Replaced manual fetch() + timer handling with HTTPFetcher composition - Uses structured error objects with translation keys - Inherits smart retry strategies (401/403, 429, 5xx backoff) - Inherits timeout handling (30s) and AbortController - Removed js/module_functions.js (scheduleTimer no longer needed) - Removed #module_functions import from package.json
khassel
approved these changes
Jan 29, 2026
rejas
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the Newsfeed module to use the centralized HTTPFetcher class (introduced in #4016), following the same pattern as the Calendar module.
This continues the refactoring effort to centralize HTTP error handling across all modules.
Changes
NewsfeedFetcher:
node_helper.js:
errorInfo.translationKeyfetcher.url,fetcher.items)Cleanup:
js/module_functions.js(scheduleTimerno longer needed)#module_functionsimport from package.jsonRelated
Part of the HTTPFetcher migration effort started in #4016.
Next candidate: Weather module (client-side → server-side migration).