Skip to content

Catching pause state #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattloose merged 2 commits into from
Feb 25, 2026
Merged

Catching pause state #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2491a74
Catching pause state
mattloose Feb 25, 2026
6357a64
Addressing failed test
mattloose Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/readfish/_read_until_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,17 @@
from readfish._loggers import setup_logger
from grpc import RpcError

# Check against these states to determine if Minknow is under the impression
# The run has fully begun and readfish can be started
# Check against these states to determine if MinKNOW still considers the run
# active enough for readfish to remain connected.
ACCEPTABLE_ACQUISITION_STATES = {
AcquisitionState.ACQUISITION_RUNNING,
AcquisitionState.ACQUISITION_STARTING,
}
# Some MinKNOW versions expose explicit pause states. Treat them as non-terminal
# so readfish waits for sequencing to resume instead of disconnecting.
for _state_name in ("ACQUISITION_PAUSING", "ACQUISITION_PAUSED"):
if hasattr(AcquisitionState, _state_name):
ACCEPTABLE_ACQUISITION_STATES.add(getattr(AcquisitionState, _state_name))
# Any but these two states suggest the run has stopped
ACCEPTABLE_PROTOCOL_STATES = {
protocol_service.PROTOCOL_RUNNING,
Expand Down
4 changes: 2 additions & 2 deletions src/readfish/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,9 @@ def get_flowcell_array(flowcell_size: int) -> npt.ArrayLike:
Traceback (most recent call last):
...
ValueError: flowcell_size is not recognised
>>> get_flowcell_array(126)[9][-1]
>>> int(get_flowcell_array(126)[9][-1])
0
>>> get_flowcell_array(512)[15][-1]
>>> int(get_flowcell_array(512)[15][-1])
1

"""
Expand Down