This repository was archived by the owner on Feb 17, 2021. It is now read-only.
Fixed Potential truncation issue in LabelLayout#260
Merged
pa1-linkedin merged 1 commit intoLinkedInAttic:masterfrom Jun 17, 2019
Merged
Conversation
Contributor
p-jadhav
commented
Jun 7, 2019
p-jadhav
commented
- Added line break mode support in LabelLayout to calculate correct size based on line break mode.
- Added LabelLayout unit test to verify that size calculation logic considers line break mode while calculating LabelLayout size.
- These changes are duplicate of pull request Fixed Potential truncation issue in LabelLayout #229
Contributor
Author
|
|
pa1-linkedin
approved these changes
Jun 11, 2019
- Added line break mode support in LabelLayout to calculate correct size based on line break mode. - Added LabelLayout unit test to verify that size calculation logic considers line break mode while calculating LabelLayout size.
p-jadhav
force-pushed
the
LabelLayout_HeightCalculation_Fix
branch
from
ec0a345 to
c874993
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.