Production checking changed from config('app.key') to config('app.env')#86
Open
mepsd wants to merge 1 commit intoLavaLite:8.xfrom
Open
Production checking changed from config('app.key') to config('app.env')#86mepsd wants to merge 1 commit intoLavaLite:8.xfrom
mepsd wants to merge 1 commit intoLavaLite:8.xfrom
Conversation
I think this is better to check with APP_ENV instead of APP_KEY because in local as well this is going to show application is in production let me know your throughts on this Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is better to check with APP_ENV instead of APP_KEY because in local as well this is going to show application is in production
let me know your throughts on this
and Filesystem $finder and constructor is also not needed let me know what do you say about that
Thanks