Importer: Refactor Registration #1003
Open
+298
−391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the growing number of importers added, this PR refactors by using WordPress filters and actions to register the importers, and adds the
convertkit_get_form_importersmethod to fetch the registered importers. This follows the pattern used for registering blocks (convertkit_get_blocks) and shortcodes (convertkit_get_shortcodes)This will mean the importers/migrators can be displayed on the Setup Wizard screen as an extra step in a future PR, if new Plugin installations detect third party form shortcodes/blocks.
Testing
Existing tests pass.
Checklist