feat(vscode): redesign profile tab#355
Open
bernaferrari wants to merge 4 commits intoKilo-Org:devfrom
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
bernaferrari
force-pushed
the
profile-tab-redesign
branch
from
474b957 to
76bf62f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still testing what kind of PR is easier to read/review/approve, since it depends on many factors (I'm so afraid I'm opening as a draft, but it is ready).
This one is mostly a UI refactor, hooking up translations and bringing some functionality from the old extension. It is not hooked up into backend (should it be? Right now there is no front-end and no back-end, is it better to have front-end without back-end?) and I added a TODO for telemetry.
I think it can be valuable and time reviewing is less than the time implementing. My goal is to try to help.
This is the screenshot from yesterday (I already tweaked the svg size a bit):