fix: add missing createdOnPlatform for security-agent and app-builder#383
Merged
pedroheyerdahl merged 4 commits intomainfrom Feb 20, 2026
Merged
fix: add missing createdOnPlatform for security-agent and app-builder#383pedroheyerdahl merged 4 commits intomainfrom
pedroheyerdahl merged 4 commits intomainfrom
Conversation
…d security-agent sessions Pass createdOnPlatform to session creation calls so sandbox LLM requests are attributed to the correct feature: - app-builder: set 'app-builder' in prepareLegacySession - security-agent: set 'security-agent' in startSecurityAnalysis - Update analysis-service test to assert createdOnPlatform Refresh feature tracking plan to reflect normalized recent changes and status
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR adds missing Code changes:
Documentation: The plan document ( Files Reviewed (4 files)
|
chrarnoldus
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #307 (microdollar feature tracking).
Problem
Two code paths were spawning cloud-agent sessions without passing
createdOnPlatform, causing their LLM usage to be attributed ascloud-agentinstead of the correct feature.Changes
Security Agent sandbox analysis (
src/lib/security-agent/services/analysis-service.ts)createdOnPlatform: 'security-agent'to theinitiateSessionStreamcallApp Builder legacy session backfill (
src/lib/app-builder/app-builder-service.ts)createdOnPlatform: 'app-builder'to theprepareLegacySessioncallPlan docs (
plans/microdollar-feature-tracking.md)Testing
pnpm typecheckpassespnpm test -- src/lib/security-agent/services/analysis-service.test.tspasses (assertscreatedOnPlatform: 'security-agent'in the mock call)