fix(auth): use constant-time comparison for internal API secret validation#304
Merged
fix(auth): use constant-time comparison for internal API secret validation#304
Conversation
…ation (AF-5) Replace short-circuit !== string comparison with timing-safe XOR-based comparison for INTERNAL_API_SECRET in kiloclaw to prevent theoretical timing side channel attacks
![kiloconnect[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (3 files)
|
…SafeEqual for INTERNAL_API_SECRET in kiloclaw. Uses dummy self-comparison on length mismatch to avoid leaking secret length via timing side-channel. Adds vitest setup to polyfill crypto.subtle.timingSafeEqual for Node test env.
pandemicsyn
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(auth): use constant-time comparison for internal API secret validation (AF-5)
Replace short-circuit !== string comparison with timing-safe XOR-based comparison for INTERNAL_API_SECRET in kiloclaw to prevent theoretical timing side channel attacks