fix(kiloclaw): detect app name hash collisions on Fly app creation#299
Merged
fix(kiloclaw): detect app name hash collisions on Fly app creation#299
Conversation
On 409 (app already exists), verify ownership by listing machines and checking userId metadata. Throws AppNameCollisionError if the existing app belongs to a different user, preventing silent network namespace sharing from SHA-256 truncation collisions. Fails open if machine listing errors to preserve existing retry behavior. Legacy machines without metadata are treated as safe (no false positives).
Fixes CI typecheck failure where TypeScript inferred a union type for the headers variable that wasn't assignable to HeadersInit.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Well-structured security fix for SHA-256 hash truncation collisions in Fly app naming. The Files Reviewed (4 files)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 409 (app already exists), verify ownership by listing machines and checking userId metadata.
Throws AppNameCollisionError if the existing app belongs to a different user, preventing silent network namespace sharing from SHA-256 truncation collisions.
Fails open if machine listing errors to preserve existing retry behavior. Legacy machines without metadata are treated as safe (no false positives).