CloudAgentNext - Move cli_sessions_v2 creation to session-ingest RPC#242
Open
CloudAgentNext - Move cli_sessions_v2 creation to session-ingest RPC#242
Conversation
![kiloconnect[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Overview
Issue Details (click to expand)WARNING
Files Reviewed (25 files)
|
Replace backend tRPC calls (createV2, linkCloudAgent, delete) with direct session-ingest WorkerEntrypoint RPC methods (createSessionForCloudAgent, deleteSessionForCloudAgent). This removes the roundtrip through the Next.js backend for session record management and moves the DB write closer to the worker that owns the table. - Convert session-ingest from plain Hono export to WorkerEntrypoint class - Add createSessionForCloudAgent / deleteSessionForCloudAgent RPC methods - Add SessionIngestBinding type declarations for both workers - Remove linkKiloSessionInBackend from DO, session-service, and ingest handler - Remove cli_sessions_v2 inserts from Next.js routers - Add rollback logic in session-prepare when DO prepare() fails - Upgrade cloudflare-session-ingest vitest to v3.2.4 - Add created_on_platform to session-ingest RPC
eshurakov
force-pushed
the
eshurakov/cloud-agent-next-cli-session
branch
from
7a5b531 to
ff70997
Compare
eshurakov
commented
Feb 17, 2026
| throw new Error('Cannot link session: KILOCODE_BACKEND_BASE_URL not configured'); | ||
| } | ||
|
|
||
| const response = await fetch(`${backendUrl}/api/cloud-sessions/linkSessions`, { |
Contributor
Author
There was a problem hiding this comment.
this endpoint doesn't even exist :-)
Replace session-ingest-binding.d.ts files with regular .ts files that use explicit exports/imports, consistent with the rest of the codebase.
Extract RPC methods into SessionIngestRPC WorkerEntrypoint class in its own file, reverting index.ts to export default app. Consumers reference the named entrypoint via wrangler.jsonc service binding config. Also adds try/catch + logging around RPC calls in session-service.ts.
iscekic
approved these changes
Feb 17, 2026
Contributor
There was a problem hiding this comment.
I wonder if we could extract some functions for reuse 🤔
Contributor
Author
There was a problem hiding this comment.
definitely, can do a service layer
| throw new Error( | ||
| `Session ${sessionId} has no kiloSessionId in metadata. Cannot restore snapshot.` | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
[WARNING]: Cold-start resume now hard-fails for sessions without kiloSessionId in DO metadata
Pre-existing sessions that were created before kiloSessionId was persisted in metadata will fail to cold-start resume with this error. Previously, restoreSessionSnapshot used the authToken to call the HTTP export API, so it didn't need kiloSessionId in metadata.
Is there a migration path for these sessions, or is this an acceptable breaking change? If sessions are short-lived enough that no pre-existing ones will attempt cold-start resume, this is fine — but worth confirming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Cloud Agent Next to use the Ingest Service to pre-create CLI sessions and add a link between Cloud Agent Session and CLI session.