Open
Conversation
added 2 commits
June 25, 2016 11:34
This currently fails, though it passes if f5 is uses instead of f6.
There will still be problems if hessian is called with a gradient or with a symbolic differentiantion type argument. This solve the bug reported in PR 91, construed narrowly. That is, the specific invocation that wasn't work now works; the general problem of asymmetric Hessians remains.
Author
|
The value for the second derivative of the second argument is not very accurate. The hessian in the above test computes a value of 8832.66, but the true value is 8833.06977. I'm not sure what degree of accuracy is reasonable to expect. I added the following tests (not in the public commits) which show asymmetric result if the gradient is defined, as well as precision failures for the [2,2] term of the hessian. BTW, the [2,2] term computed with the gradient appears correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#91 partial fix. As noted in the last commit message, there are still quite a few ways to get an asymmetric Hessian.