Change all Array and Vector to AbstractArray and AbstractVector#87
Change all Array and Vector to AbstractArray and AbstractVector#87biogeo wants to merge 1 commit intoJuliaMath:masterfrom
Conversation
|
Could you add some tests of this functionality? |
|
Sure, I'm not sure exactly what to test though. Is it reasonable to add a dependency on, e.g., DataFrames for the purposes of testing with a |
|
You could add a testing dependency on DataFrames (i.e., in |
|
Sounds good, will do when I have a chance. |
5f24f6b to
c6719c7
Compare
|
I added tests, essentially by replicating existing tests using |
|
Travis tests for Julia nightly release seem to be failing, but not on a line that makes sense to me based on anything I changed. |
|
I can confirm that I get the same test failure when running |
|
I guess this requires changing |
Changing all
ArrayandVectortype specifications in method signatures toAbstractArrayandAbstractVectorto make code more generic, as per #86.