Conversation
Contributor
Author
|
I've been thinking and I'm not sure this is needed. The current implementation allows access to all the types of arity. let x =
option<string array> "--test"
|> arity (ArgumentArity(1, 3))
|> arity ArgumentArity.ExactlyOne
|> arity ArgumentArity.OneOrMore
|> arity ArgumentArity.Zero
|> arity ArgumentArity.ZeroOrMore
|> arity ArgumentArity.ZeroOrOneAlso My code (minus the previous two) just removes the need to prefix with let x =
option<string array> "--test"
|> arity (ArgumentArity (1, 3))
|> arity ExactlyOne
|> arity OneOrMore
|> arity Zero
|> arity ZeroOrMore
|> arity ZeroOrOneWhat do you think? |
Owner
|
I was going back and forth on it earlier and am still undecided. As you said, using the built-in properties like OTOH, the DU is a bit more F# like. |
Contributor
Author
|
I do prefer the F# style using the DU. The original method is a mix of F# and direct calls to S.CL. Though it works well, it smells a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add other types of
ArgumentArity.