Push inventory window directly instead of through message queue#2756
Open
TwelveEyes wants to merge 3 commits intoInterkarma:masterfrom
Open
Push inventory window directly instead of through message queue#2756TwelveEyes wants to merge 3 commits intoInterkarma:masterfrom
TwelveEyes wants to merge 3 commits intoInterkarma:masterfrom
Conversation
Contributor
Author
|
Added a commit to fix selecting yes on the dungeon wagon access prompt. |
Collaborator
|
I think it would be simpler to just limit the change to the Inventory. I get the dependence on a real-world object in the case of the loot, but the wagon and knight reward seem to handle it in their own way, not needing an actual loot pile in the world to exist. |
Contributor
Author
|
I reverted the changes to knightly order and wagon prompts. I think they were very likely unnecessary anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occasionally activating a loot container (e.g. a loot pile, a corpse, a store shelf, a quest reward, etc) would open the inventory and the
lootTargetwould somehow be null — the inventory would open but the loot column on the right would just be the ground instead of the loot container. It seems to always happen upon the very first activation of a loot container after a load of a save game.The cause may be a possible race condition between the
lootTargetbeing set and the UI message queue being processed. Pushing the UI window directly instead of going through the UI message queue seems to solve this.Dungeon wagon access prompts and knightly order armor reward prompts have been changed as well, just in case this bug affects them too.