fix: rename param name for list_secrets method#17
Merged
varonix0 merged 1 commit intoInfisical:mainfrom Jan 14, 2025
Merged
Conversation
varonix0
approved these changes
Jan 14, 2025
Member
|
Great catch! This will be included in the next release, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today I noticed an issue in the SDK that the
list_secretsmethod of theV3RawSecretsclass does not filter results by tags, even when thetag_filtersparameter is specified.Did some research and found out that in the API the parameter value should be specified as
tagSlugs, nottag_slugs. When I changed this parameter, the result became filtered. Please accept the changes.