fix: changing the pydantic BaseSecret model value metadata to secretMetadata#16
fix: changing the pydantic BaseSecret model value metadata to secretMetadata#16MaxLikesCode wants to merge 2 commits intoInfisical:mainfrom
Conversation
…etadata The sdk is currently throwing a TypeError (TypeError: BaseSecret.__init__() got an unexpected keyword argument 'secretMetadata'). This change fixes it.
|
Hey @MaxLikesCode, I believe it'd be good if we did not remove the Adding secretMetadata would do the job instead of replacing it, correct me if I am wrong, Cheers! |
- Add metadata back to BaseSecret - Add SecretMetadata pydantic model - Add secretMetadata to BaseSecret
Yeah, you were correct. I added metadata back to the BaseSecret and created a new pydantic model for the secretMetadata. That should fix it. Let me know if you find something else. |
|
Installed the package with the changes and it seems to work fine now. |
|
Great - how do we get this reviewed, merged and released? |
|
Resolved in #18 |
The sdk is currently throwing a Type error when trying to call
list_secretsorget_secret_by_name.TypeError: BaseSecret.__init__() got an unexpected keyword argument 'secretMetadata'.It also throws an APIError when trying to call
create_secret_by_nameorupdate_secret_by_name.raise APIError( infisical_sdk.infisical_requests.APIError: [{'code': 'invalid_type', 'expected': 'string', 'received': 'undefined', 'path': ['secretValue'], 'message': 'Required'}] (Status: 422)This change fixes the error.