feat: pydantic removal, custom http requests, flake8 formatting#12
Merged
feat: pydantic removal, custom http requests, flake8 formatting#12
Conversation
varonix0
changed the title
maidul98
approved these changes
Jan 7, 2025
Contributor
There was a problem hiding this comment.
Code looks good. Right after you megre this, can you open another PR to:
Add a notice on top of the read me to explain the big diff between the two versions + link to the old read me docs for the previous version? This way people won't be confused.
Also i think you forgot to delete the docs folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves us away from the OpenAPI Generator that we were previously using. We are now instead using a custom request library that I built around the requests library. I've removed everything related to the OpenAPI generator, hence why the PR size is as big as it is.
On a smaller note, I also added proper Flake8 formatting to all the files.