CodeWars_Fox class_RPGSAGA#7
Open
N-N0th1n9 wants to merge 9 commits intoISUCT:Tsyganov_Vladislav_Vasilevichfrom
Open
CodeWars_Fox class_RPGSAGA#7N-N0th1n9 wants to merge 9 commits intoISUCT:Tsyganov_Vladislav_Vasilevichfrom
N-N0th1n9 wants to merge 9 commits intoISUCT:Tsyganov_Vladislav_Vasilevichfrom
Conversation
added 2 commits
September 30, 2023 23:51
Author
|
Цыганов Влад 2/42 |
jskonst
reviewed
Oct 11, 2023
| export default class Fox { | ||
| private readonly aName: string; | ||
| private aYear: number; | ||
| color: string; |
jskonst
reviewed
Oct 11, 2023
rpgsaga/saga/src/fox.ts
Outdated
|
|
||
| static createFoxWithoutInfo(): Fox { | ||
| const fox = new Fox('Unknown Fox', 'Unknown Color'); | ||
| delete fox.year; |
Contributor
There was a problem hiding this comment.
удаление свойств не самая лучшая практика
jskonst
reviewed
Oct 11, 2023
rpgsaga/saga/src/fox.ts
Outdated
| console.log(`${this.name} hunts ${prey}`); | ||
| } | ||
|
|
||
| static createFoxWithoutInfo(): Fox { |
Contributor
There was a problem hiding this comment.
выглядит очень странно, сделайте просто вариацию конструктора, которая позволяет работать без указанного поля
jskonst
reviewed
Oct 11, 2023
rpgsaga/saga/src/fox.ts
Outdated
Comment on lines
53
to
55
| makeSound(): void { | ||
| console.log('The fox makes a squeaky sound.'); | ||
| } |
Contributor
There was a problem hiding this comment.
лучше возвращать строковое представление, иначе протестировать не получится
jskonst
reviewed
Oct 11, 2023
rpgsaga/saga/src/fox.ts
Outdated
| this.aYear = year >= 2000 && year < 2023 ? year : this.aYear >= 2000 && this.aYear < 2023 ? this.aYear : 2000; | ||
| } | ||
|
|
||
| infoAboutFox(): void { |
Contributor
There was a problem hiding this comment.
так тут уже понятно что fox - можно просто info
jskonst
reviewed
Oct 11, 2023
rpgsaga/saga/tests/fox.spec.ts
Outdated
|
|
||
| it('should log the correct information about the fox', () => { | ||
| const test = new Fox('Foxy', 'Red', 2015); | ||
| const consoleSpy = jest.spyOn(console, 'log'); |
Contributor
There was a problem hiding this comment.
- за spyOn, но все же концептуально лучше чтобы класс возвращал значения а не выводил их в консоль, а за вывод в консоль может кто-то друго отвечать
jskonst
reviewed
Oct 11, 2023
rpgsaga/saga/tests/fox.spec.ts
Outdated
| }); | ||
| }); | ||
|
|
||
| describe('Testing fox methods', () => { |
Contributor
There was a problem hiding this comment.
можно разнести по файлам, и точно нужно разнести по describe, внутри которого может быть несколько тестов для конкретного метода
jskonst
requested changes
Nov 18, 2023
rpgsaga/saga/src/fox.ts
Outdated
| } | ||
|
|
||
| set year(year: number) { | ||
| this.aYear = year >= 2000 && year < 2023 ? year : this.aYear >= 2000 && this.aYear < 2023 ? this.aYear : 2000; |
Author
|
Я постарался исправить все ошибки кроме первой, так как не понял, как вы хотите из этого сделать enum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeWars yse