Operator Runtime Config Rotating Store Verticle#1405
Open
BehnamMozafari wants to merge 8 commits intomainfrom
Open
Operator Runtime Config Rotating Store Verticle#1405BehnamMozafari wants to merge 8 commits intomainfrom
BehnamMozafari wants to merge 8 commits intomainfrom
Conversation
added 8 commits
February 13, 2025 14:51
- Retrieves operator remote config from core endpoint
- updated local and integ config - moved runtime-config-defaults.json to runtime_config/metadata.json in com.uid2.core - moved createStoreVerticles method to complete before initialiseConfigService
…Rotating runtime config store
BehnamMozafari
commented
Feb 13, 2025
Comment on lines
+338
to
+348
| ConfigRetriever dynamicConfigRetriever = ConfigRetrieverFactory.create( | ||
| vertx, | ||
| new JsonObject() | ||
| .put("type", "event-bus") | ||
| .put("config", new JsonObject() | ||
| .put("address", OperatorRuntimeConfigEventBus)) | ||
| ); | ||
|
|
||
| this.createStoreVerticles() | ||
| .compose(v -> this.initialiseConfigService(dynamicConfigRetriever)) | ||
| .compose(configService -> { |
Contributor
Author
There was a problem hiding this comment.
Reason for this change ->createStoreVerticles method needs to be before initialiseConfigService so that the runtime config is retrieved from core and published to event-bus. dynamicConfigRetriever needs to listen to runtime config address on event bus before publishing config otherwise the message will be discarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime_config_pathandruntime_config_refresh_ms