Improve build system output and simplify Vite config#244
Open
Improve build system output and simplify Vite config#244
Conversation
- Add build-print crate for better build output formatting (info/warn/error macros) - Use standard `npm run build` instead of `build:custom` script - Remove build timestamp banner from Vite output - Improve TypeScript const typing in Vite config The build-print macros provide cleaner, more readable build output compared to raw cargo:warning println! statements.
aram356
added
enhancement
aram356
force-pushed
the
feature/build-system-improvements
branch
3 times, most recently
from
b0f4447 to
97e991c
Compare
- Remove unused `build:custom` npm script from package.json - Downgrade npm install failure from error! to warn! (execution continues) - Remove unused `error` import from build_print - Replace `npm.clone()` with `npm.as_deref()` to avoid unnecessary allocations - Include Cargo.lock for build-print dependency
aram356
force-pushed
the
feature/build-system-improvements
branch
from
97e991c to
f1768cc
Compare
aram356
requested review from
ChristianPavilonis,
jevansnyc and
prk-Jr
and removed request for
jevansnyc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-printcrate for better build output formatting usinginfo!,warn!, anderror!macrosnpm run buildinstead ofbuild:customscriptBefore
After
Test plan
cargo buildshows improved output formatnpm run buildincrates/js/libstill worksDependencies
None - this PR is independent and can be merged at any time.
Closes #252
Related to #179