Simplify TSJS core library - remove rendering/auction logic#243
Draft
aram356 wants to merge 1 commit intofeature/gam-integration-frontendfrom
Draft
Simplify TSJS core library - remove rendering/auction logic#243aram356 wants to merge 1 commit intofeature/gam-integration-frontendfrom
aram356 wants to merge 1 commit intofeature/gam-integration-frontendfrom
Conversation
This is a breaking change that removes the ad rendering and auction logic from the core library, keeping only configuration and logging. ## Removed APIs - `tsjs.addAdUnits()` - ad unit registration - `tsjs.renderAdUnit()` - single ad unit rendering - `tsjs.renderAllAdUnits()` - batch ad unit rendering - `tsjs.requestAds()` - auction request - `tsjs.getHighestCpmBids()` - bid retrieval - `tsjs.que` - command queue ## Kept APIs - `tsjs.version` - version string - `tsjs.setConfig()` - configuration - `tsjs.getConfig()` - get current config - `tsjs.log` - logging utilities ## Removed Files - core/queue.ts, registry.ts, render.ts, request.ts, util.ts - core/styles/normalize.css, core/templates/iframe.html - integrations/ext/ (Prebid shim - replaced by prebid integration) - integrations/testlight/ (obsolete test integration) ## Migration Use the GAM interceptor integration for rendering Prebid creatives, or the Prebid NPM integration for server-side bidding. Bundle size reduced from ~32KB to ~23KB (gzipped: ~7.5KB).
aram356
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed APIs
tsjs.addAdUnits()- ad unit registrationtsjs.renderAdUnit()- single ad unit renderingtsjs.renderAllAdUnits()- batch ad unit renderingtsjs.requestAds()- auction requesttsjs.getHighestCpmBids()- bid retrievaltsjs.que- command queueKept APIs
tsjs.version- version stringtsjs.setConfig()- configurationtsjs.getConfig()- get current configtsjs.log- logging utilitiesRemoved Files
core/queue.ts,registry.ts,render.ts,request.ts,util.tscore/styles/normalize.css,core/templates/iframe.htmlintegrations/ext/(Prebid shim - replaced by prebid integration)integrations/testlight/(obsolete test integration)Bundle Size
Reduced from ~32KB to ~23KB (gzipped: ~7.5KB)
Migration Path
Test plan
npm run buildsucceedsnpm testpasseswindow.tsjssetConfig,getConfig,log) still workDependencies
Closes #251
Related to #179