Add DataDome bot protection integration#231
Open
ChristianPavilonis wants to merge 2 commits intomainfrom
Open
Conversation
ChristianPavilonis
force-pushed
the
feature/datadome-integration-christian
branch
from
26a3699 to
d5f40db
Compare
6 tasks
ChristianPavilonis
force-pushed
the
feature/datadome-integration-christian
branch
from
a9f1552 to
c6f1536
Compare
ChristianPavilonis
force-pushed
the
feature/datadome-integration-christian
branch
from
c6f1536 to
2143b2b
Compare
aram356
requested changes
Feb 5, 2026
| # ANY /integrations/datadome/js/* - Signal collection API | ||
| [integrations.datadome] | ||
| enabled = false | ||
| # js_key = "YOUR_DATADOME_JS_KEY" # Optional: for auto-injecting DataDome config |
Collaborator
There was a problem hiding this comment.
🔧 js_key not used in the implementation. Is that a mistake?
|
|
||
| /// Configuration for `DataDome` integration. | ||
| #[derive(Debug, Clone, Deserialize, Validate)] | ||
| pub struct DataDomeConfig { |
Collaborator
There was a problem hiding this comment.
🔧 Where is config for js_key?
| // - '//js.datadome.co/js/check' | ||
| // - "api-js.datadome.co/js/check" | ||
| // - "js.datadome.co" | ||
| let pattern = Regex::new(r#"(['"])(https?:)?(//)?(api-)?js\.datadome\.co(/[^'"]*)?(['"])"#) |
Collaborator
There was a problem hiding this comment.
🔧 Should be a const with
use once_cell::sync::Lazy;
static DATADOME_URL_PATTERN: Lazy<Regex> = Lazy::new(|| {
Regex::new(r#"(['"])(https?:)?(//)?(api-)?js\.datadome\.co(/[^'"]*)?(['"])"#)
.expect("DataDome URL rewrite regex should compile")
});
| @@ -0,0 +1,185 @@ | |||
| import { log } from '../../core/log'; | |||
Collaborator
There was a problem hiding this comment.
❓ Should we have a common JS implementation for this? We have Permutive and Lockr and should have common reusable implementation.
| // Invalid: | ||
| // - https://cdn.example.com/js.datadome.co.js (domain is not js.datadome.co) | ||
| return ( | ||
| lower.includes('://js.datadome.co/') || |
Collaborator
There was a problem hiding this comment.
⛏️ Seems we can make a little cleaner.
❓ What about api-js.datadome.co urls?
| /// Handle the /tags.js endpoint - fetch and rewrite the `DataDome` SDK. | ||
| async fn handle_tags_js( | ||
| &self, | ||
| _settings: &Settings, |
Collaborator
There was a problem hiding this comment.
⛏️ Let's not pass parameters we don't need
|
|
||
| /// Handle the /js/* signal collection endpoint - proxy pass-through to api-js.datadome.co. | ||
| async fn handle_js_api( | ||
| &self, |
Collaborator
There was a problem hiding this comment.
⛏️ Let's not pass parameters we don't need
aram356
requested changes
Feb 5, 2026
| @@ -0,0 +1,781 @@ | |||
| //! `DataDome` integration for bot protection and security. | |||
Collaborator
There was a problem hiding this comment.
🔧 Still need comprehensive summary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61