Open
Conversation
The base64 decode in compute_encrypted_sha256_token cannot fail because it operates on data just encoded by encode_url. Changed from silent error recovery to an explicit expect with documentation explaining the invariant. Resolves: #192
ChristianPavilonis
requested changes
Jan 29, 2026
Collaborator
ChristianPavilonis
left a comment
ChristianPavilonis
left a comment
There was a problem hiding this comment.
The issue #192 has 5 files to look at.
If they didn't require changes please state why those unwrap(), unwrap_or_default(), etc. are not an issue.
The unwraps in proxy.rs are in the tests but could probably use expects in case those tests fail for better visibility as to why they failed.
When tests fail, expect provides descriptive error messages instead of generic panic locations. This makes debugging test failures much faster by immediately showing what operation failed. Changes across 19 files, 164+ conversions total. The only exclusion is build.rs which explicitly allows unwrap via clippy directive.
…n-production-code
…n-production-code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace unwrap() with expect() or ? operator in production code
Resolves: #192