Fully Integrate Minecraft Dict Environments#60
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR works to make Minecraft environments more generally compatible with the ILR training framework, including those environments that have Dict Action/Environment spaces
NOTE: This is a draft PR until the branches
torch_conversionand thenilr_wrappersget merged intorealistic_benchmarks, since the functionality here depends on implements new to those branches.Modifications in this branch:
env_cfgconfig entry, and have those wrap both the observations/actions coming from the loaded dataset, and also the actual live environment (Previously, there was single hardcoded wrapper applied to all Minecraft envs)realistic_benchmarks) for environments that require it (i.e. environments with Dict-like Action spaces)realistic_benchmarks, which relies onminerlbeing installed)