Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
File.appendis wrong in js target with hxnodejs on macOS haxe#12573According to the posix standard, when using pwrite (in our case, passing this.pos to writeSync), the O_APPEND flag is ignored.
Linux doesn't comply with this, but Mac does, so we have to make the code compatible by passing null as the position which means write will be used instead of pwrite.
See:
https://pubs.opengroup.org/onlinepubs/9799919799/functions/pwrite.html
Revert FileSystem.deleteDirectory should be recursive #85, because haxe specifies that
deleteDirectoryonly works on empty directories. It also didn't throw if the folder didn't exist.See: https://api.haxe.org/sys/FileSystem.html#deleteDirectory
Create file in File.update if it doesn't exist
This is specified by haxe and other targets also do this.