Fix #5525: 修复 Task 进度异常的问题

[Glavo]

No description provided.

[Copilot]

Pull request overview

This PR fixes a critical logic bug in the Task.updateProgress(long count, long total) method where the comparison condition was inverted, causing progress to be incorrectly calculated. The bug would have resulted in progress being set to 100% when tasks were just starting (when total >= count), and attempting to calculate progress as count/total when count exceeded total.

Changes:

• Fixed inverted condition in updateProgress method: changed if (total >= count) to if (count >= total) to correctly set progress to 1.0 when the task is complete

Comments suppressed due to low confidence (1)

HMCLCore/src/main/java/org/jackhuang/hmcl/task/Task.java:355

• The updateProgress method lacks test coverage. Consider adding unit tests to verify the progress calculation logic, especially for edge cases:

• When count equals total (should return 1.0)
• When count is less than total (should return count/total)
• When count exceeds total (should return 1.0, not > 1.0)

This would have caught the original bug where the condition was inverted.

    protected void updateProgress(long count, long total) {
        if (count < 0 || total < 0)
            throw new IllegalArgumentException("Invalid count or total: count=" + count + ", total=" + total);

        double progress;
        if (count >= total)
            progress = 1.0;
        else
            progress = (double) count / total;
        updateProgress(progress);
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.