Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the mod download details layout so the top “introduction/description” section stays fixed while only the version list scrolls, addressing the UX issue shown in the attachment and noting interaction with #5421 (ScrollPane rounded-corner behavior while scrolling).
Changes:
- Removed the outer
ScrollPanethat wrapped the whole page content. - Wrapped the versions
ComponentListinside a newScrollPaneand set it as theSpinnerPanecontent. - Updated the root skin content to render the
VBox panedirectly instead of the old outer scroll container.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| scrollPane.setFitToHeight(true); | ||
|
|
||
| HBox descriptionPane = new HBox(8); | ||
| descriptionPane.setMinHeight(Region.USE_PREF_SIZE); |
There was a problem hiding this comment.
After removing the outer ScrollPane, the header/description area is no longer scrollable. Because content.getSubtitleLabel().setWrapText(true) and descriptionPane.setMinHeight(Region.USE_PREF_SIZE), a long mod description can grow the header to its full preferred height and leave the versions list with little/zero visible space, with no way to scroll to the list. Consider constraining the description area (e.g., cap its max height / clamp subtitle lines / remove the USE_PREF_SIZE min-height so it can shrink) so the versions list remains reachable at small window heights or with long descriptions.
| descriptionPane.setMinHeight(Region.USE_PREF_SIZE); |
2026-02-06.16.11.21.mov
上面为更改前,下面为更改后
会受到 #5421 影响