Skip to content

[Enhancement] 下载界面简介不滚动#5458

Open
Calboot wants to merge 1 commit intoHMCL-dev:mainfrom
Calboot:download-page
Open

[Enhancement] 下载界面简介不滚动#5458
Calboot wants to merge 1 commit intoHMCL-dev:mainfrom
Calboot:download-page

Conversation

@Calboot
Copy link
Contributor

@Calboot Calboot commented Feb 6, 2026

2026-02-06.16.11.21.mov

上面为更改前,下面为更改后

会受到 #5421 影响

@Calboot Calboot marked this pull request as ready for review February 6, 2026 08:12
@Glavo Glavo requested a review from Copilot February 11, 2026 13:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the mod download details layout so the top “introduction/description” section stays fixed while only the version list scrolls, addressing the UX issue shown in the attachment and noting interaction with #5421 (ScrollPane rounded-corner behavior while scrolling).

Changes:

  • Removed the outer ScrollPane that wrapped the whole page content.
  • Wrapped the versions ComponentList inside a new ScrollPane and set it as the SpinnerPane content.
  • Updated the root skin content to render the VBox pane directly instead of the old outer scroll container.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

scrollPane.setFitToHeight(true);

HBox descriptionPane = new HBox(8);
descriptionPane.setMinHeight(Region.USE_PREF_SIZE);
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the outer ScrollPane, the header/description area is no longer scrollable. Because content.getSubtitleLabel().setWrapText(true) and descriptionPane.setMinHeight(Region.USE_PREF_SIZE), a long mod description can grow the header to its full preferred height and leave the versions list with little/zero visible space, with no way to scroll to the list. Consider constraining the description area (e.g., cap its max height / clamp subtitle lines / remove the USE_PREF_SIZE min-height so it can shrink) so the versions list remains reachable at small window heights or with long descriptions.

Suggested change
descriptionPane.setMinHeight(Region.USE_PREF_SIZE);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant