feat: 在服务端整合包中优先使用 Modrinth/CurseForge 下载链接#5384
Open
link-fgfgui wants to merge 2 commits intoHMCL-dev:mainfrom
Open
feat: 在服务端整合包中优先使用 Modrinth/CurseForge 下载链接#5384link-fgfgui wants to merge 2 commits intoHMCL-dev:mainfrom
link-fgfgui wants to merge 2 commits intoHMCL-dev:mainfrom
Conversation
在导出服务端整合包时,为 Mod 自动匹配 Modrinth 和 CurseForge 下载链接并写入 `server-manifest.json`。 在安装或更新服务端整合包时,优先使用清单中提供的下载链接,从而节省服务端带宽。 HMCL-dev#5241
Author
|
未做并行优化,打包效率可能较低 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements automatic matching of Modrinth and CurseForge download links for mods when exporting server modpacks, and uses these links preferentially during installation/updates to reduce server bandwidth usage.
Changes:
- Modified server modpack export to automatically detect and include Modrinth/CurseForge download URLs for JAR files in the manifest
- Updated server modpack installation/update logic to prioritize manifest-provided download URLs over the file API fallback
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ServerModpackExportTask.java | Adds logic to query Modrinth and CurseForge for remote download URLs of JAR files and include them in the server-manifest.json |
| ServerModpackCompletionTask.java | Modifies download logic to use downloadURL from manifest when available, falling back to fileApi path if not provided |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
在导出服务端整合包时,为 Mod 自动匹配 Modrinth 和 CurseForge 下载链接并写入
server-manifest.json。 在安装或更新服务端整合包时,优先使用清单中提供的下载链接,从而节省服务端带宽。实现#5241