[Feature] 让HMCL可以识别到JIJ的打包形式并以FlowPane的形式显示，并支持搜索和导出JIJ信息，且在崩溃时若有JIJ信息则一并打包至压缩包内 by NoClassFoundError · Pull Request #5383 · HMCL-dev/HMCL

NoClassFoundError · 2026-01-31T14:52:40Z

No description provided.

NoClassFoundError · 2026-01-31T14:53:45Z

#5332

Minecraft269 · 2026-01-31T16:26:24Z

下载来源


wtf?

Minecraft269 · 2026-02-01T03:14:53Z

为什么不能像这样呢?

NoClassFoundError · 2026-02-01T11:59:37Z

@3gf8jv4dv 请求进行i18n补全，我这里打开zh全是乱码

NoClassFoundError · 2026-02-01T12:01:32Z

参考译文：
mods.built_in=Built-in
内置
mods.built_in.cancleexport=No mod contains JIJ information, the operation will be canceled.
无JIJ信息包含，操作将取消。
mods.built_in.exportJIJINFO=Export The JIJ INFO
导出JIJ信息
mods.built_in.exportAllJIJINFO=Export All JIJ INFO
导出所有JIJ信息
mods.built_in.mods=Built-in Mods
内置模组
mods.built_in.noresult=No matching results
没有匹配结果
mods.built_in.search=Search Built-in Mods
搜索内置模组
若翻译有误请见谅，感谢。

3gf8jv4dv · 2026-02-01T12:04:50Z

@3gf8jv4dv 请求进行i18n补全，我这里打开zh全是乱码

zh 是仅繁体还是简繁？按理说不应该呀。所有 i18n 文件都是 UTF-8 编码。

NoClassFoundError · 2026-02-01T12:05:24Z

@3gf8jv4dv 请求进行i18n补全，我这里打开zh全是乱码

zh 是仅繁体还是简繁？按理说不应该呀。所有 i18n 文件都是 UTF-8 编码。

我这里全是ISO

NoClassFoundError · 2026-02-01T12:05:55Z

3gf8jv4dv · 2026-02-01T12:10:29Z

@NoClassFoundError 这个编辑器的设置应该能改，你可以搜一下。我看下译文。

NoClassFoundError · 2026-02-01T12:17:40Z

好的，等我回去研究一下

Damselettecolumbiahyperseleneia · 2026-02-02T13:22:16Z

cc @3gf8jv4dv

HMCL/src/main/resources/assets/lang/I18N.properties

HMCL/src/main/resources/assets/lang/I18N_zh.properties

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

HMCL/src/main/resources/assets/lang/I18N.properties

Damselettecolumbiahyperseleneia · 2026-02-02T14:24:49Z

cc @3gf8jv4dv

3gf8jv4dv

lgtm 💃🕺

WhatDamon

粗略看了一下，本地化似乎还是有点问题

HMCL/src/main/resources/assets/lang/I18N.properties

HMCL/src/main/resources/assets/lang/I18N_zh.properties

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

Damselettecolumbiahyperseleneia

修改已完成

3gf8jv4dv

我们来看看 Glavo 怎么说。

3gf8jv4dv · 2026-02-03T13:17:12Z

前面已经解决的评论，请点击 Resolve Conversation

3gf8jv4dv · 2026-02-07T05:15:25Z

HMCL/src/main/resources/assets/lang/I18N.properties


 extension.bat=Windows Batch File
+extension.file=Text documents
+extension.mod=Mod File


这个下面已经有了，重复了。

Copilot

Pull request overview

该 PR 为 HMCL 增加对 Mod Jar-in-Jar（JiJ / nested jars）信息的识别、展示、搜索与导出能力，并在导出崩溃日志压缩包时附带 JiJ 信息清单，便于排障与信息收集。

Changes:

在 Fabric / Quilt / Forge(1.13+) 元数据解析中提取 JiJ（nested jars / jarjar）列表并写入 LocalModFile
新增“嵌套模组管理”页面（FlowPane 弹窗展示、支持搜索与导出 JiJ 信息）并挂到版本管理侧边栏
崩溃日志导出时额外打包 mod 列表与 JiJ 信息（ALL_MOD_JIJ_INFO.txt）

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/QuiltModMetadata.java	解析 quilt.mod.json 中的 nested jars 列表并传入 `LocalModFile`
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/PackMcMeta.java	适配 `LocalModFile` 新增的 bundledMods 参数（空列表）
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/LiteModMetadata.java	同上，补齐 bundledMods 参数（空列表）
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/ForgeOldModMetadata.java	同上，补齐 bundledMods 参数（空列表）
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/ForgeNewModMetadata.java	解析 `META-INF/jarjar/metadata.json` 并写入 bundledMods
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/FabricModMetadata.java	解析 fabric.mod.json 的 `jars` 字段并写入 bundledMods
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalModFile.java	为每个 mod file 增加 bundledMods 存储与查询接口
HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties	新增嵌套模组管理相关文案与文件类型文案
HMCL/src/main/resources/assets/lang/I18N_zh.properties	同上（繁体）
HMCL/src/main/resources/assets/lang/I18N.properties	同上（英文）
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/VersionPage.java	侧边栏新增“嵌套模组管理”入口与折叠交互
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/BuiltInModListPageSkin.java	新增页面皮肤：展示/搜索/导出 JiJ 信息
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/BuiltInModListPage.java	新增页面逻辑：拉取包含 JiJ 的 mod 列表
HMCL/src/main/java/org/jackhuang/hmcl/ui/SVG.java	新增导出与 stacks 图标以支持新 UI
HMCL/src/main/java/org/jackhuang/hmcl/game/LogExporter.java	崩溃日志压缩包中附带 mod 列表与 JiJ 信息文件

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-07T12:48:40Z

HMCL/src/main/java/org/jackhuang/hmcl/game/LogExporter.java

+                    }
+
+                    if (!hasJij) {
+                        infoBuilder.append("No JIJ INFO contain").append(System.lineSeparator());


The fallback message No JIJ INFO contain is grammatically incorrect and may be confusing in the exported report. Consider changing it to something clearer like “No JiJ info found.”

Suggested change

infoBuilder.append("No JIJ INFO contain").append(System.lineSeparator());

infoBuilder.append("No JiJ info found.").append(System.lineSeparator());

Copilot · 2026-02-07T12:48:41Z

HMCL/src/main/resources/assets/lang/I18N.properties

 mods.add.failed=Failed to add mod %s.
 mods.add.success=%s was successfully added.
+mods.built_in=Nested
+mods.built_in.cancleexport=No mod contains JiJ information. The operation will be canceled.


The i18n key name mods.built_in.cancleexport contains a typo (“cancle”). Since this key is referenced from code, it’s easy for the typo to spread and makes future maintenance harder. Consider renaming it to mods.built_in.cancel_export (or similar) and updating all locale files + code references accordingly.

Suggested change

mods.built_in.cancleexport=No mod contains JiJ information. The operation will be canceled.

mods.built_in.cancel_export=No mod contains JiJ information. The operation will be canceled.

Copilot · 2026-02-07T12:48:41Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/VersionPage.java

+        tab = new TabHeader(transitionPane, versionSettingsTab, installerListTab, modListTab,builtInModListTab, resourcePackTab, worldListTab, schematicsTab);
        tab.select(versionSettingsTab);


Missing space after comma in the TabHeader constructor call (modListTab,builtInModListTab). This is inconsistent with the formatting used elsewhere in the file and makes the argument list harder to scan.

Copilot · 2026-02-07T12:48:41Z

HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalModFile.java

        this.gameVersion = gameVersion;
        this.url = url;
        this.logoPath = logoPath;
+        this.bundledMods = bundledMods;


bundledMods is stored as-is and can be null or externally mutable. Consider normalizing it in the constructor (e.g., default to an empty list when null and store an unmodifiable/defensive copy) so callers can safely use getBundledMods() without repeated null/immutability checks.

Suggested change

this.bundledMods = bundledMods;

List<String> safeBundledMods = bundledMods == null

? Collections.emptyList()

: Collections.unmodifiableList(new ArrayList<>(bundledMods));

this.bundledMods = safeBundledMods;

Copilot · 2026-02-07T12:48:42Z

HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/FabricModMetadata.java

+    public FabricModMetadata(String id, String name, String version, String icon, String description, List<FabricModAuthor> authors, Map<String, String> contact,List<FabricNestedJar> jars) {
        this.id = id;


Constructor parameter list is missing a space after the comma (contact,List...), which is inconsistent with the surrounding style and hurts readability.

Copilot · 2026-02-07T12:48:42Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/BuiltInModListPageSkin.java

+    private void search() {
+        isSearching = true;
+        Bindings.unbindContent(listView.getItems(), getSkinnable().getItems());
+
+        String queryString = searchField.getText();


isSearching is set in search() and reset when closing the search bar, but it is never read, and the ListView is unbound from getSkinnable().getItems() during search. This means a refresh() (or any async update to getItems()) won’t update the visible results while searching. Consider either removing isSearching and keeping the binding, or adding an items-change listener (similar to ModListPageSkin) that re-runs search() when getSkinnable().getItems() changes while searching.

Copilot · 2026-02-07T12:48:42Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/BuiltInModListPageSkin.java

+        }
+
+        if (!hasData) {
+            FXUtils.runInFX(() -> Controllers.confirm(i18n("mods.built_in.cancleexport"), i18n("button.ok"), () -> {}, null));


This uses Controllers.confirm(...), which renders a Yes/No dialog, but the UI text/action suggests this is an informational “OK only” message when there is no JiJ data to export. Consider using Controllers.dialog(...) (or another one-button dialog API) instead of confirm here.

Suggested change

FXUtils.runInFX(() -> Controllers.confirm(i18n("mods.built_in.cancleexport"), i18n("button.ok"), () -> {}, null));

FXUtils.runInFX(() -> Controllers.dialog(i18n("mods.built_in.cancleexport")));

[Feature] JIJ

ad6d3a6

NoClassFoundError added 4 commits February 1, 2026 01:37

update

8f20d8a

update

aeb8a1b

update

e98ccb1

update

949e2bd

NoClassFoundError added 15 commits February 1, 2026 15:48

update

cdd8a36

update

0a6f120

update

8ecce95

update

df4d36c

Merge branch 'HMCL-dev:main' into 5332JIJ

508a6f3

move the BuiltinmodPage to ModListPage

28c3d82

update

a5f884d

update

d916fd8

update i18n

93851df

update

5ed5394

update logexporter:package All_JIJ_INFO.txt to zip

bbfcf61

update

718abd2

update

eb7b0ee

update

0779f9f

Merge branch 'HMCL-dev:main' into 5332JIJ

d323993

update

aea9cbb

NoClassFoundError added 2 commits February 2, 2026 21:31

update

f327bc7

Merge branch 'HMCL-dev:main' into 5332JIJ

dd3deca

3gf8jv4dv reviewed Feb 2, 2026

View reviewed changes

HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved

HMCL/src/main/resources/assets/lang/I18N_zh.properties Outdated Show resolved Hide resolved

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties Outdated Show resolved Hide resolved

3gf8jv4dv reviewed Feb 2, 2026

View reviewed changes

HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved

update

57d465b

3gf8jv4dv reviewed Feb 2, 2026

View reviewed changes

WhatDamon reviewed Feb 3, 2026

View reviewed changes

HMCL/src/main/resources/assets/lang/I18N.properties Outdated Show resolved Hide resolved

HMCL/src/main/resources/assets/lang/I18N_zh.properties Outdated Show resolved Hide resolved

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties Outdated Show resolved Hide resolved

NoClassFoundError marked this pull request as draft February 3, 2026 12:40

NoClassFoundError requested a review from Damselettecolumbiahyperseleneia February 3, 2026 12:41

update i18n

a0eeb66

Damselettecolumbiahyperseleneia approved these changes Feb 3, 2026

View reviewed changes

NoClassFoundError requested review from 3gf8jv4dv and WhatDamon February 3, 2026 13:13

3gf8jv4dv reviewed Feb 3, 2026

View reviewed changes

NoClassFoundError marked this pull request as ready for review February 3, 2026 13:15

WhatDamon approved these changes Feb 3, 2026

View reviewed changes

NoClassFoundError added 2 commits February 3, 2026 21:58

Merge branch 'HMCL-dev:main' into 5332JIJ

b3d838d

Merge branch 'main' into 5332JIJ

363bbb9

3gf8jv4dv reviewed Feb 7, 2026

View reviewed changes

NoClassFoundError added 2 commits February 7, 2026 17:47

update

772728f

update

5ccf3f4

Glavo requested a review from Copilot February 7, 2026 12:44

Copilot started reviewing on behalf of Glavo February 7, 2026 12:44 View session

Copilot AI reviewed Feb 7, 2026

View reviewed changes

NoClassFoundError added 2 commits February 9, 2026 20:11

update

0cc4938

Merge branch 'HMCL-dev:main' into 5332JIJ

7d93b4f

	infoBuilder.append("No JIJ INFO contain").append(System.lineSeparator());
	infoBuilder.append("No JiJ info found.").append(System.lineSeparator());

	mods.built_in.cancleexport=No mod contains JiJ information. The operation will be canceled.
	mods.built_in.cancel_export=No mod contains JiJ information. The operation will be canceled.

		tab = new TabHeader(transitionPane, versionSettingsTab, installerListTab, modListTab,builtInModListTab, resourcePackTab, worldListTab, schematicsTab);
		tab.select(versionSettingsTab);

-        this.bundledMods = bundledMods;
+        List<String> safeBundledMods = bundledMods == null
+                ? Collections.emptyList()
+                : Collections.unmodifiableList(new ArrayList<>(bundledMods));
+        this.bundledMods = safeBundledMods;

		public FabricModMetadata(String id, String name, String version, String icon, String description, List<FabricModAuthor> authors, Map<String, String> contact,List<FabricNestedJar> jars) {
		this.id = id;

	FXUtils.runInFX(() -> Controllers.confirm(i18n("mods.built_in.cancleexport"), i18n("button.ok"), () -> {}, null));
	FXUtils.runInFX(() -> Controllers.dialog(i18n("mods.built_in.cancleexport")));

Conversation

NoClassFoundError commented Jan 31, 2026

Uh oh!

NoClassFoundError commented Jan 31, 2026

Uh oh!

Minecraft269 commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Minecraft269 commented Feb 1, 2026

Uh oh!

NoClassFoundError commented Feb 1, 2026

Uh oh!

NoClassFoundError commented Feb 1, 2026

Uh oh!

3gf8jv4dv commented Feb 1, 2026

Uh oh!

NoClassFoundError commented Feb 1, 2026

Uh oh!

NoClassFoundError commented Feb 1, 2026

Uh oh!

3gf8jv4dv commented Feb 1, 2026

Uh oh!

NoClassFoundError commented Feb 1, 2026

Uh oh!

Damselettecolumbiahyperseleneia commented Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Damselettecolumbiahyperseleneia commented Feb 2, 2026

Uh oh!

3gf8jv4dv left a comment

Choose a reason for hiding this comment

Uh oh!

WhatDamon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Damselettecolumbiahyperseleneia left a comment

Choose a reason for hiding this comment

Uh oh!

3gf8jv4dv left a comment

Choose a reason for hiding this comment

Uh oh!

3gf8jv4dv commented Feb 3, 2026

Uh oh!

3gf8jv4dv Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Minecraft269 commented Jan 31, 2026 •

edited

Loading