Open
Conversation
LAGIdiot
requested changes
Mar 31, 2021
Member
LAGIdiot
left a comment
LAGIdiot
left a comment
There was a problem hiding this comment.
Thanks for your hard work. There are few areas which needs adjustment and one big question regarding performance
src/main/java/gregtech/common/metatileentities/electric/MetaTileEntityPump.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/electric/MetaTileEntityPump.java
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/electric/MetaTileEntityPump.java
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/electric/MetaTileEntityPump.java
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/electric/MetaTileEntityPump.java
Show resolved
Hide resolved
LAGIdiot
added
rsr: revision
Collaborator
|
I have edited the opening comment to link the related issue, so that it will be closed when this is merged. |
Contributor
Author
|
So what do you think of the current state of this PR @LAGIdiot ? is there any other changes needed or anything else ? |
| amountIterated++; | ||
| } | ||
| checkPos = blocksToCheck.poll(); | ||
| private BlockPos getValidPos(Deque<BlockPos> posDeque) { |
Collaborator
There was a problem hiding this comment.
The passed argument is unused in this method. Any reason for not removing it?
Contributor
Author
There was a problem hiding this comment.
That's a copy paste fail the arg should get used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Added support for liquid filters in pumps (machines)
How solved:
Added a fluid filter widget to the UI, check for liquid type when adding them to the queue and just before pumping the block (to avoid bug in case of block replacement or filter update). Invalidate the queue when switching filter from black/whitelist to white/blacklist and removing/adding the filter.
Outcome:
Closes #1532. Adds a Fluid Filter slot to the pump
Additional info:
Screenshots of UI :
Possible compatibility issue:
None Expected.