fix: added a len check before draining #3630
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@adamgerhant review pls ! |
Member
|
When we do this with a Vec2 Value, this error is the expected outcome: 
In your video, we see something different: 
This is not the expected behavior. It likely means your initial approach is masking the underlying problem instead of tracing back to its root cause. |
Author
|
@Keavon i have added default unit value input so that the identity node can function properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3629
issue: node.inputs tries to drain from the index 1 which causes the crash
fix: added a len check before draining
before:
Screen.Recording.2026-01-13.at.11.02.05.AM.mov
after:
Screen.Recording.2026-01-13.at.11.00.56.AM.mov